pkg/47831: lang/ruby193-base typo in patch-configure(.in) for DragonFly and FreeBSD

[davshao%gmail.com@localhost]

>Number:         47831
>Category:       pkg
>Synopsis:       lang/ruby193-base typo in patch-configure(.in) for DragonFly 
>and FreeBSD
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 18 02:05:00 +0000 2013
>Originator:     David Shao
>Release:        DragonFly 3.5-DEVELOPMENT x86_64
>Organization:
>Environment:
DragonFly 3.5-DEVELOPMENT x86_64
>Description:
There is a typo in patch-configure(.in) in current pkgsrc lang/ruby193-base 
1.9.3-p429 that causes the build on DragonFly and presumably FreeBSD to fail 
with a linking error:

linking static-library libruby193-static.a
linking shared-library libruby193.so.191
generating encdb.h
encdb.h unchanged
making enc
compiling ./enc/encdb.c
linking encoding encdb.so
/usr/libexec/binutils222/elf/ld.bfd: cannot find -lruby193
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/lang/ruby193-base/work/ruby-1.9.3-p429
*** Error code 1


>How-To-Repeat:

>Fix:
The typo in patch-configure and patch-configure.in (should both patches be 
fixed?) can be fixed with the following patch fragment:

-@@ -16796,7 +16812,7 @@ _ACEOF
+@@ -16810,7 +16826,7 @@ _ACEOF
    freebsd*|dragonfly*) :

        SOLIBS='$(LIBS)'
 -      LIBRUBY_SO='lib$(RUBY_SO_NAME).so.$(MAJOR)$(MINOR)'
-+      LIBRUBY_SO='lib$(RUBY_SO_NAME).so.$(MAJOR)$(MINOR)\$(TEENY)'
++      LIBRUBY_SO='lib$(RUBY_SO_NAME).so.$(MAJOR)$(MINOR)$(TEENY)'
        if test "$rb_cv_binary_elf" != "yes" ; then
            LIBRUBY_SO="$LIBRUBY_SO.\$(TEENY)"
            LIBRUBY_ALIASES=''

An extra backslash was added before $(TEENY) resulting in a wrongly named link 
to a lib.

Actually looking at the NetBSD configuration code, I am not sure if the goal is 
to name the library

libruby193.so.191
or
libruby193.so.19.1

In any case it should not be the observed
libruby193.so.19?