Re: pkg/46639: irssi port disables ncurses on non-NetBSD platforms

[Matthew Mondor <mm_lists%pulsar-zone.net@localhost>]

The following reply was made to PR pkg/46639; it has been noted by GNATS.

From: Matthew Mondor <mm_lists%pulsar-zone.net@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/46639: irssi port disables ncurses on non-NetBSD platforms
Date: Thu, 5 Jul 2012 18:29:02 -0400

 --MP_/H7aFGaJBXyRHlFkFfeL_obX
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 On Sat, 30 Jun 2012 01:15:04 +0000 (UTC)
 Matthew Mondor <mm_lists%pulsar-zone.net@localhost> wrote:
 
 >  Example diff attached (untested, and sorry for not providing it against
 >  -current pkgsrc, but it should give an idea)
 
 The modifications were this time applied to -current pkgsrc's irssi
 package (which is already the latest irssi release) and tested using
 both terminfo and ncurses options.  New patch attached.
 
 Unfortunately there's no official irssi maintainer to contact, and I
 can't commit, any volunteer to review and commit? :)
 
 Thanks,
 -- 
 Matt
 
 --MP_/H7aFGaJBXyRHlFkFfeL_obX
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=pkgsrc-chat-irssi-diff.txt
 
 Index: Makefile
 ===================================================================
 RCS file: /data/rsync/netbsd-cvs/pkgsrc/chat/irssi/Makefile,v
 retrieving revision 1.58
 diff -u -r1.58 Makefile
 --- Makefile   3 Mar 2012 00:12:48 -0000       1.58
 +++ Makefile   5 Jul 2012 22:13:28 -0000
 @@ -20,9 +20,7 @@
  USE_LIBTOOL=          yes
  USE_TOOLS+=           pkg-config
  
 -CONFIGURE_ARGS+=      --with-terminfo \
 -                      --with-proxy \
 -                      --without-ncurses \
 +CONFIGURE_ARGS+=      --with-proxy \
                        --sysconfdir=${PKG_SYSCONFDIR}
  
  EGDIR=                ${PREFIX}/share/examples/irssi
 Index: options.mk
 ===================================================================
 RCS file: /data/rsync/netbsd-cvs/pkgsrc/chat/irssi/options.mk,v
 retrieving revision 1.10
 diff -u -r1.10 options.mk
 --- options.mk 6 Mar 2011 04:12:09 -0000       1.10
 +++ options.mk 30 Jun 2012 01:07:09 -0000
 @@ -1,12 +1,28 @@
  # $NetBSD: options.mk,v 1.10 2011/03/06 04:12:09 dholland Exp $
  
  PKG_OPTIONS_VAR=      PKG_OPTIONS.irssi
 +PKG_OPTIONS_REQUIRED_GROUPS= display
 +PKG_OPTIONS_GROUP.display= terminfo ncurses
  PKG_SUPPORTED_OPTIONS=        inet6 perl ssl
  PKG_SUGGESTED_OPTIONS=        inet6
  PKG_OPTIONS_LEGACY_OPTS+=     irssi-perl:perl
 +.if ${OPSYS} == "NetBSD"
 +PKG_SUGGESTED_OPTIONS+= terminfo
 +.else
 +PKG_SUGGESTED_OPTIONS+= ncurses
 +.endif
  
  .include "../../mk/bsd.options.mk"
  
 +.if !empty(PKG_OPTIONS:Mterminfo)
 +CONFIGURE_ARGS+=      --with-terminfo --without-ncurses
 +.endif
 +
 +.if !empty(PKG_OPTIONS:Mncurses)
 +.include "../../devel/ncurses/buildlink3.mk"
 +CONFIGURE_ARGS+=      --without-terminfo --with-ncurses
 +.endif
 +
  .if !empty(PKG_OPTIONS:Mperl)
  USE_TOOLS+=           perl:run
  PERL5_PACKLIST=               auto/Irssi/.packlist
 
 --MP_/H7aFGaJBXyRHlFkFfeL_obX--