[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/46382: lintpkgsrc may overflow /bin/sh command line length
The following reply was made to PR pkg/46382; it has been noted by GNATS.
From: David Holland <dholland-pbugs%netbsd.org@localhost>
Subject: Re: pkg/46382: lintpkgsrc may overflow /bin/sh command line length
Date: Thu, 26 Apr 2012 16:11:59 +0000
On Thu, Apr 26, 2012 at 01:05:00PM +0000, he%NetBSD.org@localhost wrote:
> Here is a draft fix which works, but which uses the "mktemp"
> utility. It is possible or maybe even probable that this is
> not sufficiently portable, and that we'd instead have to resort
> to something like /tmp/pl-sumfiles.$$, which isn't quite as
> safe. Suggestions welcome.
You have a useless use of cat in there.
But more importantly: does perl not allow something like
open(DIGEST, "| xargs digest $sum |")
so you can just feed the file list through? Or is Perl paralyzed by
the same foolishness that disallows this kind of thing using popen(3)?
(And failing that, doesn't Perl have mkstemp?)
David A. Holland
Main Index |
Thread Index |