[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/45940: audio/csound5 PLIST error (or faulty recent update)
The following reply was made to PR pkg/45940; it has been noted by GNATS.
From: Robert Elz <kre%munnari.OZ.AU@localhost>
Subject: Re: pkg/45940: audio/csound5 PLIST error (or faulty recent update)
Date: Wed, 15 Feb 2012 01:03:26 +0700
Date: Tue, 7 Feb 2012 21:20:16 +0000 (UTC)
From: Steven Drake <sbd%NetBSD.org@localhost>
| Hopefully it will now.
Yes, that is fine now thanks, PR can close.
| Wrong way round, its good practice to bump the PKGREVISION if the PLIST
I understood that, except "good practice" is too soft I think, it is
required - the change in PKGREVISION wasn't my point.
The point was, that the PLIST cannot change in a non-broken package
without something (of substance) in the package changing - that might
be altering an option setting, adding dependencies, an extra patch,
(new code version as well of course) - but if something is building
correctly, and this one was (at least on NetBSD - or it seemed to be)
then simply changing the PLIST without any other change is always wrong.
Here the only other change (of any kind) was the PKGREVISION bump, and that
by itself isn't the kind of change that can possibly cause PLIST to alter,
so something simply had to be wrong.
Now you found and fixed the config botch that was causing the NetBSD build
(and DragonFly apparently) to be different from the Linux build, and that
certinly is the kind of change that can change the PLIST (and hence need
a revbump) - but the first update did not have that.
Everyone should use this as a reminder, if you fix something for one
platform, that is not a change to some platform only code, always ask
why it worked (or seemed to work) on other platforms - like this time,
you might have just found a bug that had not previously been noticed,
otherwise, perhaps you are introducing one.
Main Index |
Thread Index |