pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/44696: Support for diverse make-compatible MAKE_PROGRAMs [patch]

>Number:         44696
>Category:       pkg
>Synopsis:       Support for diverse make-like MAKE_PROGRAMs [patch]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 07 23:35:00 +0000 2011
>Originator:     Aleksey Cheusov
>Release:        NetBSD 5.1
System: NetBSD 5.1 NetBSD 5.1 (GENERIC) #0: Mon Jan 31 
23:53:52 EET 2011 
Architecture: x86_64
Machine: amd64
A number of packages in pkgsrc use make-like programs (none of
the following: imake, bmake, gmake) for building the package. For this
purpose they set MAKE_PROGRAM variable directly in package's Makefile
because it is simplier than rewriting do-build and/or do-install targets.

Due to


line in mk/tools/, MAKE_PROGRAM=make-like-tool statement is placed 

 .include ""

in order to override `='. This looks ugly. Also pkglint complains
about such assignment.  I propose to change MAKE_PROGRAM variable acl
in pkglint and to use ?= instead of =. Patch is below.

Index: mk/tools/
RCS file: /cvsroot/pkgsrc/mk/tools/,v
retrieving revision 1.13
diff -u -r1.13
--- mk/tools/    17 Jul 2005 21:36:24 -0000      1.13
+++ mk/tools/    7 Mar 2011 23:10:23 -0000
@@ -52,7 +52,7 @@
 .elif !empty(_USE_TOOLS:Mimake) && defined(IMAKE_MAKE)
-MAKE_PROGRAM=          ${MAKE}
+MAKE_PROGRAM?=         ${MAKE}
 TOOLS_CREATE+=         make
Index: pkgtools/pkglint/files/
RCS file: /cvsroot/pkgsrc/pkgtools/pkglint/files/,v
retrieving revision 1.208
diff -u -r1.208
--- pkgtools/pkglint/files/ 10 Feb 2011 12:08:04 -0000      1.208
+++ pkgtools/pkglint/files/ 7 Mar 2011 23:10:23 -0000
@@ -435,7 +435,7 @@
 MAKE_FLAGS             List of ShellWord [$package_list]
 MAKE_JOBS              Integer [$user]
 MAKE_JOBS_SAFE         YesNo [$package]
-MAKE_PROGRAM           ShellCommand [$system]
+MAKE_PROGRAM           ShellCommand [$package]
 MANCOMPRESSED          YesNo [m:s,c:ds]
 MANGRP                 UserGroupName [$system]

Home | Main Index | Thread Index | Old Index