pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/44633: Support --disable-sdl option for emulators/qemu



>Number:         44633
>Category:       pkg
>Synopsis:       Support --disable-sdl option for emulators/qemu
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 25 12:50:00 +0000 2011
>Originator:     Silas Silva
>Release:        NetBSD 5.0
>Organization:
>Environment:
System: NetBSD red 5.0 NetBSD 5.0 (XEN3_DOMU) #0: Sun Apr 26 19:10:36 UTC 2009 
builds%b6.netbsd.org@localhost:/home/builds/ab/netbsd-5-0-RELEASE/i386/200904260229Z-obj/home/builds/ab/netbsd-5-0-RELEASE/src/sys/arch/i386/compile/XEN3_DOMU
 i386
Architecture: i386
Machine: i386
>Description:
        emulators/qemu work fine, but nobody can run it in a machine that that
        has no X11 libraries (even with the -no-graphic runtime option).  The
        --disable-sdl option is enough to prevent it from linking against X11
        libraries.

        I've tested it in NetBSD 5.0 with py-anita and it runs really fine.
>How-To-Repeat:
        Install emulators/qemu in a machine without X11 (you can make package
        in another one and bring it where there is no X11) and try to run it.
>Fix:
        Using the options framework, the following patches give the user
        the choice on using sdl or not:

        Index: Makefile
        ===================================================================
        RCS file: /cvsroot/pkgsrc/emulators/qemu/Makefile,v
        retrieving revision 1.77
        diff -u -p -r1.77 Makefile
        --- Makefile    27 Dec 2010 12:33:32 -0000      1.77
        +++ Makefile    24 Feb 2011 20:22:55 -0000
        @@ -107,9 +107,10 @@ post-install:
                ${INSTALL_DATA} ${FILESDIR}/Makefile.multinode-NetBSD \
                        ${DESTDIR}${PREFIX}/share/doc/qemu/
         
        +.include "options.mk"
        +
         # On Darwin, qemu uses Cocoa and CoreAudio
         .if empty(OPSYS:MDarwin)
        -.include "../../devel/SDL/buildlink3.mk"
         .include "../../mk/oss.buildlink3.mk"
         .endif
         .include "../../devel/zlib/buildlink3.mk"
        Index: options.mk
        ===================================================================
        RCS file: options.mk
        diff -N options.mk
        --- /dev/null   1 Jan 1970 00:00:00 -0000
        +++ options.mk  24 Feb 2011 20:22:55 -0000
        @@ -0,0 +1,17 @@
        +# $NetBSD$
        +
        +PKG_OPTIONS_VAR=       PKG_OPTIONS.qemu
        +PKG_SUPPORTED_OPTIONS= sdl
        +PKG_SUGGESTED_OPTIONS= sdl
        +
        +.include "../../mk/bsd.options.mk"
        +
        +PLIST_VARS+=           sdl
        +
        +.if !empty(PKG_OPTIONS:Msdl)
        +CONFIGURE_ARGS+=       --enable-sdl
        +.include "../../devel/SDL/buildlink3.mk"
        +PLIST.x11=             yes
        +.else
        +CONFIGURE_ARGS+=       --disable-sdl
        +.endif



Home | Main Index | Thread Index | Old Index