Re: pkg/43113: misc/fbreader incorrect patch (maybe?)

["OBATA Akio" <obache%netbsd.org@localhost>]

The following reply was made to PR pkg/43113; it has been noted by GNATS.

From: "OBATA Akio" <obache%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/43113: misc/fbreader incorrect patch (maybe?)
Date: Mon, 05 Apr 2010 13:52:20 +0900

 On Sun, 04 Apr 2010 23:35:00 +0900, <polachok%gmail.com@localhost> wrote:
 
 > I think patches/patch-ad is incorrect.
 >
 >  #ifdef DO_ICONV_CAST
 >         iconv(myIConverter, (const char**)&in, &inSize, &out, &outSize);
 >  #else // DO_ICONV_CAST
 > -       iconv(myIConverter, &in, &inSize, &out, &outSize);
 > +       iconv(myIConverter, (const char **)&in, &inSize, &out, &outSize);
 >  #endif // DO_ICONV_CAST
 >
 > See? Now the code with #ifdef and without is the same, which it is not meant 
 > to be (I think).
 
 Probably, instead of the patch, DO_ICONV_CAST should be defined on
 certain platforms (NetBSD and Solaris?).