pkg/43113: misc/fbreader incorrect patch (maybe?)

[polachok%gmail.com@localhost]

>Number:         43113
>Category:       pkg
>Synopsis:       misc/fbreader incorrect patch (maybe?)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 04 14:35:00 +0000 2010
>Originator:     Alexander Polakov
>Release:        n/a
>Organization:
>Environment:
DragonFly noisy 2.7-DEVELOPMENT DragonFly v2.7.0.45.g5d6a9-DEVELOPMENT #16: Fri 
Apr  2 23:54:49 MSD 2010     polachok@noisy:/usr/obj/usr/src/sys/XEON  i386

>Description:
I think patches/patch-ad is incorrect. 

 #ifdef DO_ICONV_CAST
        iconv(myIConverter, (const char**)&in, &inSize, &out, &outSize);
 #else // DO_ICONV_CAST
-       iconv(myIConverter, &in, &inSize, &out, &outSize);
+       iconv(myIConverter, (const char **)&in, &inSize, &out, &outSize);
 #endif // DO_ICONV_CAST

See? Now the code with #ifdef and without is the same, which it is not meant to 
be (I think).
>How-To-Repeat:
build fbreader on dragonfly.
>Fix:
Remove patches/patch-ad, everything builds fine.