pkg/39669: multimedia/gnash doesn't build

[Magnus Henoch <mange%freemail.hu@localhost>]

>Number:         39669
>Category:       pkg
>Synopsis:       multimedia/gnash doesn't build on NetBSD/macppc
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 02 06:15:00 +0000 2008
>Originator:     Magnus Henoch
>Release:        NetBSD 4.99.72
>Organization:
        
>Environment:
        
        
System: NetBSD zemdatav 4.99.72 NetBSD 4.99.72 (IBOOK) #0: Sat Aug 23 00:43:57 
CEST 2008 magnus@zemdatav:/media/e/netbsd/obj/sys/arch/macppc/compile/IBOOK 
macppc
Architecture: powerpc
Machine: macppc
>Description:
        When I try to build multimedia/gnash, I get this error:

/usr/pkg/bin/bash ../libtool --tag=CXX   --mode=link c++  -O2 
-I/usr/pkg/include -I/usr/include -I/usr/include/krb5 
-I/usr/pkg/include/freetype2 -pthread -pthread     -W     -Wall     
-Wcast-align     -Wcast-qual     -Wpointer-arith     -Wreturn-type      
-fvisibility-inlines-hidden -module -avoid-version 
-L/usr/pkg/lib/firefox/plugins -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -L/usr/lib 
-Wl,-R/usr/lib -Wl,--as-needed -o libgnashplugin.la -rpath 
/usr/pkg/lib/firefox/plugins plugin.lo npn_gate.lo npp_gate.lo np_entry.lo  -lc 
-lX11 -lXi -lm 
c++ -shared  .libs/plugin.o .libs/npn_gate.o .libs/npp_gate.o .libs/np_entry.o  
-Wl,--rpath -Wl,/media/e/work/multimedia/gnash/work/.buildlink/lib -Wl,--rpath 
-Wl,/media/e/work/multimedia/gnash/work/.buildlink/lib 
-L/media/e/work/multimedia/gnash/work/.buildlink/lib/firefox/plugins 
-L/media/e/work/multimedia/gnash/work/.buildlink/lib -lc 
/media/e/work/multimedia/gnash/work/.buildlink/lib/libX11.so 
/media/e/work/multimedia/gnash/work/.buildlink/lib/libXi.so -lm  -pthread 
-pthread -Wl,-R/usr/pkg/lib -Wl,--as-needed -Wl,-soname -Wl,libgnashplugin.so 
-o .libs/libgnashplugin.so
.libs/plugin.o: In function `nsPluginInstance::processPlayerRequest(char*, 
unsigned int)':
plugin.cpp:(.text+0xbd8): undefined reference to `std::basic_stringbuf<char, 
std::char_traits<char>, std::allocator<char> >::str() const'
plugin.cpp:(.text+0xc10): undefined reference to `std::basic_string<char, 
std::char_traits<char>, std::allocator<char> >::~basic_string()'
plugin.cpp:(.text+0xc5c): undefined reference to `std::basic_string<char, 
std::char_traits<char>, std::allocator<char> >::~basic_string()'
plugin.cpp:(.text+0xc7c): undefined reference to `std::basic_string<char, 
std::char_traits<char>, std::allocator<char> >::~basic_string()'
plugin.cpp:(.text+0xc9c): undefined reference to `std::basic_string<char, 
std::char_traits<char>, std::allocator<char> >::~basic_string()'
plugin.cpp:(.text+0xcb4): undefined reference to `std::basic_iostream<char, 
std::char_traits<char> >::~basic_iostream()'
plugin.cpp:(.text+0xccc): undefined reference to `std::basic_string<char, 
std::char_traits<char>, std::allocator<char> >::~basic_string()'
plugin.cpp:(.text+0xd04): undefined reference to `std::basic_string<char, 
std::char_traits<char>, std::allocator<char> >::~basic_string()'
plugin.cpp:(.text+0xd30): undefined reference to `std::basic_string<char, 
std::char_traits<char>, std::allocator<char> >::~basic_string()'
plugin.cpp:(.text+0xd58): undefined reference to `std::basic_string<char, 
std::char_traits<char>, std::allocator<char> >::~basic_string()'
plugin.cpp:(.text+0xdb4): undefined reference to `std::basic_string<char, 
std::char_traits<char>, std::allocator<char> >::~basic_string()'
.libs/plugin.o:plugin.cpp:(.text+0xdc8): more undefined references to 
`std::basic_string<char, std::char_traits<char>, std::allocator<char> 
>::~basic_string()' follow
.libs/plugin.o: In function `nsPluginInstance::processPlayerRequest(char*, 
unsigned int)':
plugin.cpp:(.text+0xde8): undefined reference to `std::basic_iostream<char, 
std::char_traits<char> >::~basic_iostream()'
plugin.cpp:(.text+0xe08): undefined reference to `std::basic_string<char, 
std::char_traits<char>, std::allocator<char> >::~basic_string()'
plugin.cpp:(.text+0xe3c): undefined reference to `std::basic_string<char, 
std::char_traits<char>, std::allocator<char> >::~basic_string()'
plugin.cpp:(.text+0xeb0): undefined reference to `std::basic_iostream<char, 
std::char_traits<char> >::~basic_iostream()'
gmake[3]: *** [libgnashplugin.la] Error 1
gmake[3]: Leaving directory 
`/media/e/work/multimedia/gnash/work/gnash-0.8.3/plugin'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory 
`/media/e/work/multimedia/gnash/work/gnash-0.8.3/plugin'

>How-To-Repeat:
        cd /usr/pkgsrc/multimedia/gnash; make
>Fix:
        This more or less corresponds to upstream bug report
        https://savannah.gnu.org/bugs/?22753 , which suggests that
        -fvisibility-inlines-hidden be removed from CFLAGS.  That
        makes gnash compile and run for me.  I propose the change
        below to patch-aa.

        As this seems to be an OS-agnostic problem, testing whether
        $host_cpu is powerpc might be a better idea...

--- patch-aa.~1.10.~    2008-06-22 17:20:56.000000000 +0200
+++ patch-aa    2008-10-02 00:36:15.000000000 +0200
@@ -11,6 +11,15 @@
          # Extract the first word of "fop", so it can be a program name with 
args.
  set dummy fop; ac_word=$2
  { echo "$as_me:$LINENO: checking for $ac_word" >&5
+@@ -55115,7 +55115,7 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
+ fi
+ { echo "$as_me:$LINENO: result: $gcc_visibility_bug" >&5
+ echo "${ECHO_T}$gcc_visibility_bug" >&6; }
+-    if test x$gcc_visibility_bug = xno; then
++    if test x$gcc_visibility_bug = xno && test $host != powerpc--netbsd; then
+       CXXFLAGS="$CXXFLAGS -fvisibility-inlines-hidden"
+       if test x"$enable_visibility" != x"no"; then
+         CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
 @@ -58445,7 +58445,7 @@ fi
          echo "               This version of ffmpeg may not work!" >&3
          echo "               Version 51.27.0 or newer is highly recommended." 
>&3

>Unformatted: