Re: PR/38210 CVS commit: pkgsrc/textproc/grep

["Stuart Shelton" <srcshelton%gmail.com@localhost>]

security/libgcrypt has the same problem:

cc-1117 cc: ERROR File = visibility.c, Line = 702
  An expression appears after a "return" in a "void" function.

    return _gcry_md_hash_buffer (algo, digest, buffer, length);
           ^

cc-1117 cc: ERROR File = visibility.c, Line = 851
  An expression appears after a "return" in a "void" function.

    return _gcry_ac_io_init_va (ac_io, mode, type, ap);
           ^

2 errors detected in the compilation of "visibility.c".

... and again, the build is successful is the "return" keyword is
removed (the functions called are void functions in any case).


On 11/03/2008, Tobias Nygren <tnn%netbsd.org@localhost> wrote:
> The following reply was made to PR pkg/38210; it has been noted by GNATS.
>
>  From: Tobias Nygren <tnn%netbsd.org@localhost>
>  To: gnats-bugs%gnats.NetBSD.org@localhost
>  Cc:
>  Subject: PR/38210 CVS commit: pkgsrc/textproc/grep
>  Date: Tue, 11 Mar 2008 02:18:23 +0000 (UTC)
>
>   Module Name:   pkgsrc
>   Committed By:  tnn
>   Date:          Tue Mar 11 02:18:22 UTC 2008
>
>   Modified Files:
>         pkgsrc/textproc/grep: distinfo
>   Added Files:
>         pkgsrc/textproc/grep/patches: patch-aa
>
>   Log Message:
>   MIPSPro doesn't like code such as:
>
>   void foo(void) {}
>   void bar(void) { return foo(); }
>
>   Stripping away the return makes it happy. PR pkg/38210.
>
>
>   To generate a diff of this commit:
>   cvs rdiff -r1.8 -r1.9 pkgsrc/textproc/grep/distinfo
>   cvs rdiff -r0 -r1.5 pkgsrc/textproc/grep/patches/patch-aa
>
>   Please note that diffs are not public domain; they are subject to the
>   copyright notices on the relevant files.
>
>