Re: pkg/26448

[Robert Elz <kre%munnari.OZ.AU@localhost>]

I'll take another look at it, but I can tell you one bug
that's still there (that I mentioned ages ago when this
was under discussion before) ...

You need this patch (to bsd.pkg.mk) at the very least (you want to
do "normal" stuff either if the ftp command isn't "ftp" or if there
are no resume args set, not only when both of those is true).

Index: bsd.pkg.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.mk,v
retrieving revision 1.1540
diff -u -r1.1540 bsd.pkg.mk
--- bsd.pkg.mk  17 Nov 2004 22:55:14 -0000      1.1540
+++ bsd.pkg.mk  24 Nov 2004 09:01:26 -0000
@@ -1520,7 +1520,7 @@
                break;                                                  \
        else                                                            \
                if [ "$$dsize" -lt "$$tsize" ]; then            \
-                       if [ "${FETCH_CMD:T}" != "ftp" -a -z 
"${FETCH_RESUME_ARGS}" ]; then \
+                       if [ "${FETCH_CMD:T}" != "ftp" -o -z 
"${FETCH_RESUME_ARGS}" ]; then \
                                ${ECHO_MSG} "=> Resume transfers are not 
supported, FETCH_RESUME_ARGS is empty."; \
                                break;                                  \
                        else                                            \


You also probably want to alter the message, perhaps to say

Resume transfers are not supported, or FETCH_RESUME_ARGS is empty.

(that just added "or") - or you could make a different message for the
2 cases, but that's most probably not worth the effort.

Aside from that, I've been using this (with the above patch included)
ever since it was last updated (though with 
        FETCH_RESUME_ARGS=
in /etc/mk.conf so it is turned off) without any problems....

kre