Re: kern/60700: Enhancement and man page for PCF8583

[Dave Tyson <dtyson%anduin.org.uk@localhost>]

On 8 October 2026 08:50:02 BST, Julian Coleman via gnats <gnats-admin%NetBSD.org@localhost> wrote:
>The following reply was made to PR kern/60700; it has been noted by GNATS.
>
>From: Julian Coleman <jdc%coris.org.uk@localhost>
>To: Dave Tyson <dtyson%anduin.org.uk@localhost>
>Cc: gnats-bugs%netbsd.org@localhost
>Subject: Re: kern/60700: Enhancement and man page for PCF8583
>Date: Thu, 8 Oct 2026 09:47:43 +0200
>
> Hi,
> 
> > This is an updated patch which addresses points raised by Julian. The
> > device does not contain NVRAM and so does not retain info over power
> > down unless a battery is attached. The print lines now display the mode
> > on the attachment line. The new man page has some updates and
> > corrections.
> 
> Just a quick question/comment on the man page:
> 
> > +.Dt PCF8583
> > +.Os
> > +.Sh NAME
> > +.Nm pcf8583
> > +.Nd Driver for NPX PCF8583 Clock and Calendar/Counter/240 x 8bit RAM
> > +via I2C bus
> > +.Sh SYNOPSIS
> > +.Cd "pcfrtc* at iic? addr 0x50"
> > +.Cd "pcfrtc* at iic? addr 0x50 flags x"
> > +.Cd "pcfrtc* at iic? addr 0x51"
> > +.Cd "pcfrtc* at iic? addr 0x51 flags x"
> 
> The name is pcf8583, but in the synopsis and in the attach line:
> 
> > pcfrtc1 at iic2 addr 0x51: PCF8583 Mode 2: Counter
> 
> we have pcfrtc.  I would be tempted to rename the man page to "pcfrtc", if
> that's OK?
> 
> Regards,
> 
> Julian
> 
> -- 
> 

Yes, that's fine. I always thought it was peculiar that the attach name differed from the chip name - probably historical.

In the code patch It might be worth changing the sysctl flag CTLFLAG_READWRITE to CTLFLAG_ALLWRITE so non-root users can reset the counter stats. There are no security issues with this, but if you prefer to leave is as-is that's OK.

Dave

Dave
-- 
Sent from my Android device with K-9 Mail.