NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/60700: Enhancement and man page for PCF8583
The following reply was made to PR kern/60700; it has been noted by GNATS.
From: Dave Tyson <dtyson%anduin.org.uk@localhost>
To: gnats-bugs%netbsd.org@localhost, Julian Coleman via gnats <gnats-admin%NetBSD.org@localhost>,
kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Cc:
Subject: Re: kern/60700: Enhancement and man page for PCF8583
Date: Thu, 08 Oct 2026 09:50:07 +0100
On 8 October 2026 08:50:02 BST, Julian Coleman via gnats <gnats-admin@NetBS=
D=2Eorg> wrote:
>The following reply was made to PR kern/60700; it has been noted by GNATS=
=2E
>
>From: Julian Coleman <jdc@coris=2Eorg=2Euk>
>To: Dave Tyson <dtyson@anduin=2Eorg=2Euk>
>Cc: gnats-bugs@netbsd=2Eorg
>Subject: Re: kern/60700: Enhancement and man page for PCF8583
>Date: Thu, 8 Oct 2026 09:47:43 +0200
>
> Hi,
>=20
> > This is an updated patch which addresses points raised by Julian=2E Th=
e
> > device does not contain NVRAM and so does not retain info over power
> > down unless a battery is attached=2E The print lines now display the m=
ode
> > on the attachment line=2E The new man page has some updates and
> > corrections=2E
>=20
> Just a quick question/comment on the man page:
>=20
> > +=2EDt PCF8583
> > +=2EOs
> > +=2ESh NAME
> > +=2ENm pcf8583
> > +=2ENd Driver for NPX PCF8583 Clock and Calendar/Counter/240 x 8bit RA=
M
> > +via I2C bus
> > +=2ESh SYNOPSIS
> > +=2ECd "pcfrtc* at iic? addr 0x50"
> > +=2ECd "pcfrtc* at iic? addr 0x50 flags x"
> > +=2ECd "pcfrtc* at iic? addr 0x51"
> > +=2ECd "pcfrtc* at iic? addr 0x51 flags x"
>=20
> The name is pcf8583, but in the synopsis and in the attach line:
>=20
> > pcfrtc1 at iic2 addr 0x51: PCF8583 Mode 2: Counter
>=20
> we have pcfrtc=2E I would be tempted to rename the man page to "pcfrtc"=
, if
> that's OK?
>=20
> Regards,
>=20
> Julian
>=20
> --=20
>=20
Yes, that's fine=2E I always thought it was peculiar that the attach name =
differed from the chip name - probably historical=2E
In the code patch It might be worth changing the sysctl flag CTLFLAG_READW=
RITE to CTLFLAG_ALLWRITE so non-root users can reset the counter stats=2E T=
here are no security issues with this, but if you prefer to leave is as-is =
that's OK=2E
Dave
Dave
--=20
Sent from my Android device with K-9 Mail=2E
Home |
Main Index |
Thread Index |
Old Index