Re: bin/54944: sysinst SIGSEGV with gpt partitioned disk

[Frank Kardel <kardel%netbsd.org@localhost>]

The following reply was made to PR bin/54944; it has been noted by GNATS.

From: Frank Kardel <kardel%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: bin/54944: sysinst SIGSEGV with gpt partitioned disk
Date: Thu, 6 Feb 2020 17:40:04 +0100

 #0  0x000000016181f35b in target_already_root () at 
 /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../target.c:187
 187             for (ptn = 0; ptn < parts->num_part; ptn++) {
 (gdb) print *pm
 $1 = {refdev = 0x0, diskdev = "ld0", '\000' <repeats 26 times>, 
 diskdev_descr = "ld0 (954G)\000dk1@ld0)", '\000' <repeats 235 times>, 
 parts = 0x76e7fc597380, no_mbr = false, no_part = false, cur_system = 
 false, sectorsize = 512,
    dlcyl = 124519, dlhead = 255, dlsec = 63, dlcylsize = 16065, 
 current_cylsize = 0, dlsize = 2000409264, ptstart = 0, ptsize = 0, 
 max_chs = 0, bootstart = 0, bootsize = 0, mounted = 0x0, unsaved = 
 false, found = true, blocked = 0, l = {
      sle_next = 0x0}}
 (gdb) print pm->parts
 $2 = (struct disk_partitions *) 0x76e7fc597380
 (gdb) print *pm->parts
 $3 = {pscheme = 0x161a4abe0 <mbr_parts>, disk = 0x76e7fc8470c8 "ld0", 
 bytes_per_sector = 512, num_part = 1, disk_start = 0, disk_size = 
 2000409264, free_space = 0, parent = 0x0}
 (gdb)
 
 
 On 02/06/20 17:35, Martin Husemann wrote:
 > The following reply was made to PR bin/54944; it has been noted by GNATS.
 >
 > From: Martin Husemann <martin%duskware.de@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc:
 > Subject: Re: bin/54944: sysinst SIGSEGV with gpt partitioned disk
 > Date: Thu, 6 Feb 2020 17:32:20 +0100
 >
 >   On Thu, Feb 06, 2020 at 12:30:00PM +0000, kardel%netbsd.org@localhost wrote:
 >   > Core was generated by `sysinst'.
 >   > Program terminated with signal SIGSEGV, Segmentation fault.
 >   > #0  0x00000001f221f35b in target_already_root () at /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../target.c:187
 >   > 187             for (ptn = 0; ptn < parts->num_part; ptn++) {
 >   > (gdb) bt
 >   > #0  0x00000001f221f35b in target_already_root () at /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../target.c:187
 >   
 >   I can not reproduce nor explain it - parts comes from pm->parts and that is
 >   checked for being NULL earlier in do_upgrade.
 >   
 >   If you still have the core, can you print "*pm" and "parts" in this frame?
 >   
 >   > Additionally when I try dk1@ld0 I get "No root partition defined.  Cannot continue".
 >   > The fstab on dk1 is fine though for normal boot (parsing issue?):
 >   > /etc/fstab:
 >   > NAME=NVME\ root         /               ffs     rw               1 1
 >   
 >   Yep, it was confused by the "\ ", should be fixed.
 >   
 >   Martin
 >