Re: PR/54730 CVS commit: src/usr.sbin/postinstall

[Christos Zoulas <christos%zoulas.com@localhost>]

The following reply was made to PR bin/54730; it has been noted by GNATS.

From: Christos Zoulas <christos%zoulas.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost,
 tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: PR/54730 CVS commit: src/usr.sbin/postinstall
Date: Sun, 22 Dec 2019 10:53:21 -0500

 --Apple-Mail=_F19DAF02-B7A0-4B70-9B42-9C7276A3EACA
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 Yes, and I have not had time to understand and test it. I have not =
 committed
 anything because I don't want to make it worse. For example your latest
 patch does something special for the "etc" set, and I don't understand =
 how "etc"
 is special. Also obsolete_dir is only used in one part of the if =
 statement and
 should not be always set.
 
 christos
 
 > On Dec 21, 2019, at 9:20 PM, Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost> =
 wrote:
 >=20
 > The following reply was made to PR bin/54730; it has been noted by =
 GNATS.
 >=20
 > From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
 > To: christos%netbsd.org@localhost
 > Cc: gnats-bugs%netbsd.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
 > Subject: Re: PR/54730 CVS commit: src/usr.sbin/postinstall
 > Date: Sun, 22 Dec 2019 11:15:46 +0900
 >=20
 > I wrote:
 >=20
 >> /var/db/obsolete/etc is not extracted into ${DESTDIR}
 >> as other sets but prepared in ${ETCTGZDIR}:
 >>=20
 >> --- postinstall.in.orig	2019-12-04 20:36:27.562323424 +0900
 >> +++ postinstall.in	2019-12-04 20:37:31.591546076 +0900
 >> @@ -1465,11 +1465,18 @@
 >> # $3: setname
 >> select_obsolete_files()
 >> {
 >> +	local obsolete_dir
 >> +	if [ $3 =3D "etc" ] ;then
 >> +		obsolete_dir=3D${SRC_DIR}/var/db/obsolete
 >> +	else
 >> +		obsolete_dir=3D${DEST_DIR}/var/db/obsolete
 >> +	fi
 >> +
 >> 	if $SOURCEMODE; then
 >> 		${SED} -n -e "/obsolete/s@\.$1$2[[:space:]].*@\1@p" \
 >> 		    ${SRC_DIR}/distrib/sets/lists/$3/mi
 >> 	else
 >> -		${SED} -n -e "s@\.$1$2\$@\1@p" =
 "${DEST_DIR}/var/db/obsolete/$3"
 >> +		${SED} -n -e "s@\.$1$2\$@\1@p" "${obsolete_dir}/$3"
 >> 	fi
 >> }
 >>=20
 >>=20
 >=20
 > You have a concern (in PR/54741):
 >=20
 >  https://mail-index.netbsd.org/netbsd-bugs/2019/12/07/msg064879.html
 >>> I am worried that SRC_DIR does not work if not $SOURCEMODE, this is =
 why
 >>> I have not committed it...
 >=20
 > My answer is:
 >=20
 >  https://mail-index.netbsd.org/netbsd-bugs/2019/12/07/msg064883.html
 >>> I guess !$SOURCEMODE means $TGZMODE.
 >>> In that case SRC_DIR for the etc set is already handled,
 >>> at least it should work in select_obsolete_files():
 >=20
 > Do you have some idea about specific test cases?
 > These postinstall problems should be fixed before 9.0 release.
 >=20
 > Thanks,
 >=20
 > ---
 > Izumi Tsutsui
 >=20
 
 
 --Apple-Mail=_F19DAF02-B7A0-4B70-9B42-9C7276A3EACA
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP
 
 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - http://gpgtools.org
 
 iF0EARECAB0WIQS+BJlbqPkO0MDBdsRxESqxbLM7OgUCXf+RcQAKCRBxESqxbLM7
 OpPQAJ0agprmJmKOzxi9o2AJ70sExo0OwACg0AbjKpF9aBexqAXMp8srRLiKLes=
 =bT8y
 -----END PGP SIGNATURE-----
 
 --Apple-Mail=_F19DAF02-B7A0-4B70-9B42-9C7276A3EACA--