misc/53908: Building -current with MKKERBEROS=no and MKKMOD=no fails

[raschi.alex%gmail.com@localhost]

>Number:         53908
>Category:       misc
>Synopsis:       Building -current with MKKERBEROS=no and MKKMOD=no fails
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 25 13:30:00 +0000 2019
>Originator:     Alex Raschi
>Release:        current
>Organization:
>Environment:
NetBSD server0 8.99.30 NetBSD 8.99.30 (LOCAL) amd64
>Description:
Trying to build a very minimal base results in two build errors. I think
that MKKERBEROS=no and MKKMOD=no cause the two issues. The first error
is related to openssh, sys/socket.h doesn't get included. The second is:

=======  2 extra files in DESTDIR  =========
Files in DESTDIR but missing from flist.
File is obsolete or flist is out of date ?
------------------------------------------
./usr/tests/kernel/threadpool_tester
./usr/tests/kernel/threadpool_tester/threadpool_tester.kmod
=========  end of 2 extra files  ===========

This patch fixes the build for me:

Index: crypto/external/bsd/openssh/dist/auth-pam.c
===================================================================
RCS file: /cvsroot/src/crypto/external/bsd/openssh/dist/auth-pam.c,v
retrieving revision 1.17
diff -r1.17 auth-pam.c
69a70,72
> #ifdef USE_PAM
> #include <sys/socket.h>
> #endif
Index: tests/kernel/Makefile
===================================================================
RCS file: /cvsroot/src/tests/kernel/Makefile,v
retrieving revision 1.55
diff -r1.55 Makefile
27a28
> .if ${MKKMOD} != "no"
28a30
> .endif

If i understood correctly threadpool_tester shouldn't be built unless
modules are enabled too [1]. sys/socket.h get included by kerberos when
enabled, if the latter is disabled but at least pam is enabled we need
to include the header.

[1] http://cvsweb.netbsd.org/bsdweb.cgi/src/distrib/sets/lists/tests/module.mi?rev=1.14&content-type=text/x-cvsweb-markup&only_with_tag=MAIN
>How-To-Repeat:
Clone -current with cvs and build with:

./build.sh -j 4 -m i386 -O ../obj/i386 -T ../tools/amd64 distribution kernel=LOCAL

or something similar, i don't think that matters anyway.

src related part of /etc/mk.conf:

COPTS+=-pipe
MAKEVERBOSE=0
MKBSDTAR=yes
MKCATPAGES=no
MKCOMPAT=no
MKCTF=no
MKDTRACE=no
MKGDB=no
MKHESIOD=no
MKHTML=no
MKINFO=no
MKIPFILTER=no
MKISCSI=no
MKKERBEROS=no
MKKMOD=no
MKLDAP=no
MKLVM=no
MKMANZ=yes
MKMDNS=no
MKPF=no
MKPIE=yes
MKPIGZGZIP=yes
MKRELRO=full
MKREPRO=yes
MKRUMP=no
MKSKEY=no
MKUNBOUND=no
MKUNPRIVED=yes
MKUPDATE=yes
MKYP=no
MKZFS=no
USE_FORT=yes
USE_SSP=yes
USE_PIGZGZIP=yes
MKBSDGREP=yes
MKDTC=no
>Fix:
Apply the patch above and rebuild, remove threadpool_tester dirs if
necessary.