NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PR/53301 CVS commit: src/sys/dev/pci

The following reply was made to PR kern/53301; it has been noted by GNATS.

From: "Jaromir Dolecek" <>
Subject: PR/53301 CVS commit: src/sys/dev/pci
Date: Tue, 10 Jul 2018 18:32:25 +0000

 Module Name:	src
 Committed By:	jdolecek
 Date:		Tue Jul 10 18:32:25 UTC 2018
 Modified Files:
 	src/sys/dev/pci: if_msk.c
 Log Message:
 add callout for re-filling RX ring - it's invoked when the RX refill
 code can't get enough buffers; fixes possible stall when the RXSTAT
 interrupt arrives while no buffers are available
 idea from OpenBSD if_msk.c rev. 1.131
 as part of this remove the confusingly commented re-fill code from
 msk_jfree() and instead just invoke the callout if needed; also
 refill in msk_intr() only when running low instead of every RX intr;
 this simplifies the code, and gives small RX performance boost on
 my hardware (6%: ~38 MB/s -> ~40 MB/s)
 tested on SK-9E22 (Yukon-2 XL rev. A3) by me, and 88E8071 (Yukon-2
 Extreme rev. B0) by Jogn Halfpenny; unfortunately still doesn't
 resolve the PR kern/53301 stall
 To generate a diff of this commit:
 cvs rdiff -u -r1.71 -r1.72 src/sys/dev/pci/if_msk.c
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home | Main Index | Thread Index | Old Index