Re: PR/53178 CVS commit: src/tools

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR toolchain/53178; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: Joerg Sonnenberger <joerg%bec.de@localhost>, gnats-bugs%NetBSD.org@localhost
Cc: toolchain-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
	netbsd-bugs%netbsd.org@localhost, thorpej%me.com@localhost
Subject: Re: PR/53178 CVS commit: src/tools
Date: Sun, 15 Apr 2018 10:25:21 -0400

 On Apr 15,  3:18pm, joerg%bec.de@localhost (Joerg Sonnenberger) wrote:
 -- Subject: Re: PR/53178 CVS commit: src/tools
 
 | This is not an appropriate fix. It assumes blindly that the host
 | compiler is clang on OSX and doesn't address the reverse case of using
 | clang on non-OSX at all. There is a reason why this patch hasn't been
 | committed before.
 
 I agree, but that ship had already sailed:
 
 @@ -18,9 +18,12 @@
  .include <bsd.own.mk>
  
  # Disable use of pre-compiled headers on Darwin.
 +# GCC build exceeds the macOS clang default bracket nesting level of 256.
  BUILD_OSTYPE!= uname -s
  .if ${BUILD_OSTYPE} == "Darwin"
  HOST_CFLAGS+=-O2 -no-cpp-precomp
 +HOST_CFLAGS+=-O2 -no-cpp-precomp -fbracket-depth=512
 +HOST_CXXFLAGS+= -fbracket-depth=512
  .endif
  MAKE_PROGRAM?= ${MAKE}
 
 
 "-no-cpp-precomp" is only valid on clang, right?
 I mean this did not make the situation any worse...
 
 christos