NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: misc/49272 (Patching with Coccinelle?: Deletion of unnecessary checks before specific function calls)



Synopsis: Patching with Coccinelle?: Deletion of unnecessary checks before specific function calls

State-Changed-From-To: open->closed
State-Changed-By: dholland%NetBSD.org@localhost
State-Changed-When: Mon, 31 Oct 2016 03:33:07 +0000
State-Changed-Why:
There is at best lukewarm enthusiasm for this sort of change in NetBSD,
because of the risks of breaking things by accident when massediting.
Meanwhile, the fact that nobody has taken up this patch in two years is
suggestive: probably nobody is going to, and without someone taking the
time to crosscheck all the changes (not all the removed checks are in
front of free() -- many are other functions that might or might not be
null-safe a priori) and also fixing the places where the patches break
indentation or other adverse consequences... without someone taking the
time there is no realistic chance of this patch being useful.

Also, the patch is apparently against -6 and would need hand-merging.

So, WONTFIX.





Home | Main Index | Thread Index | Old Index