Re: bin/51264: Fix src/sbin/fsck_lfs/bufcache.c

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR bin/51264; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: bin/51264: Fix src/sbin/fsck_lfs/bufcache.c
Date: Mon, 1 Aug 2016 00:04:54 +0000

 On Sun, Jul 31, 2016 at 10:25:00PM +0000, Jose Luis Rodriguez Garcia wrote:
  >  I have seen that it is called by the cleaner daemon, but I don't know
  >  in which cases the cleaner daemon do a rehash (I haven't read any of
  >  the cleaner code yet).
 
 It is called when it reloads the ifile, which it does before cleaning
 every segment (apparently) - this will actually resize it since it
 calls bufinit() with 4, but it'll do it before it does any real work.
 And since the ifile doesn't grow on the fly unless you try to do an
 online resize, it probably won't have much effect.
 
 however, I misread that earlier.
 
 I now think pulling it up is worthwhile.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost