NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: port-arm32/50513 (Incorrect logic for atomic_nand_xx.S)
The following reply was made to PR port-arm32/50513; it has been noted by GNATS.
From: Frank Zerangue <fzerangue%mac.com@localhost>
To: gnats-bugs%NetBSD.org@localhost, dholland%NetBSD.org@localhost
Cc: port-arm32-maintainer%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost,
gnats-admin%netbsd.org@localhost
Subject: Re: port-arm32/50513 (Incorrect logic for atomic_nand_xx.S)
Date: Mon, 30 May 2016 10:11:24 -0500
--Apple-Mail=_34BE15E0-BA3E-4DAF-BCEF-9694CFA90729
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=us-ascii
Yes,
Fix committed by Nick Hudson, 12/11/2015. See below.
Frank
From: "Nick Hudson" <skrll%netbsd.org@localhost <mailto:skrll%netbsd.org@localhost>>
To: gnats-bugs%gnats.NetBSD.org@localhost <mailto:gnats-bugs%gnats.NetBSD.org@localhost>
Cc:=20
Subject: PR/50513 CVS commit: src/common/lib/libc/arch/arm/atomic
Date: Fri, 11 Dec 2015 12:41:10 +0000
Module Name: src
Committed By: skrll
Date: Fri Dec 11 12:41:10 UTC 2015
Modified Files:
src/common/lib/libc/arch/arm/atomic: atomic_nand_16.S =
atomic_nand_32.S
atomic_nand_64.S atomic_nand_8.S sync_fetch_and_nand_8.S
Log Message:
Use gcc 4.4 and later operation for nand, i.e.
*ptr =3D ~(tmp & value) instead of *ptr =3D ~tmp & value
There was also another bug in sync_fetch_and_nand_8 which I've also =
fixed.
PR port-arm32/50513: Incorrect logic for atomic_nand_xx.S
To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 =
src/common/lib/libc/arch/arm/atomic/atomic_nand_16.S \
src/common/lib/libc/arch/arm/atomic/atomic_nand_32.S \
src/common/lib/libc/arch/arm/atomic/atomic_nand_8.S
cvs rdiff -u -r1.3 -r1.4 =
src/common/lib/libc/arch/arm/atomic/atomic_nand_64.S
cvs rdiff -u -r1.4 -r1.5 \
src/common/lib/libc/arch/arm/atomic/sync_fetch_and_nand_8.S
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
> On May 29, 2016, at 11:13 PM, dholland%NetBSD.org@localhost wrote:
>=20
> Synopsis: Incorrect logic for atomic_nand_xx.S
>=20
> State-Changed-From-To: open->feedback
> State-Changed-By: dholland%NetBSD.org@localhost
> State-Changed-When: Mon, 30 May 2016 04:13:34 +0000
> State-Changed-Why:
> Is this fixed?
>=20
>=20
>=20
--Apple-Mail=_34BE15E0-BA3E-4DAF-BCEF-9694CFA90729
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
charset=us-ascii
<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html =
charset=3Dus-ascii"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" =
class=3D"">Yes,<div class=3D""><br class=3D""></div><div class=3D"">Fix =
committed by Nick Hudson, 12/11/2015. See below.</div><div class=3D""><br =
class=3D""></div><div class=3D"">Frank</div><div class=3D""><br =
class=3D""></div><div class=3D"">From: "Nick Hudson" <<a =
href=3D"mailto:skrll%netbsd.org@localhost"; class=3D"">skrll%netbsd.org@localhost</a>><br =
class=3D"">To: <a href=3D"mailto:gnats-bugs%gnats.NetBSD.org@localhost"; =
class=3D"">gnats-bugs%gnats.NetBSD.org@localhost</a><br class=3D"">Cc: <br =
class=3D"">Subject: PR/50513 CVS commit: =
src/common/lib/libc/arch/arm/atomic<br class=3D"">Date: Fri, 11 Dec 2015 =
12:41:10 +0000<br class=3D""><br class=3D"">Module Name:<span =
class=3D"Apple-tab-span" style=3D"white-space: pre;"> </span>src<br =
class=3D"">Committed By:<span class=3D"Apple-tab-span" =
style=3D"white-space: pre;"> </span>skrll<br class=3D"">Date:<span =
class=3D"Apple-tab-span" style=3D"white-space: pre;"> </span><span =
class=3D"Apple-tab-span" style=3D"white-space: pre;"> </span>Fri Dec =
11 12:41:10 UTC 2015<br class=3D""><br class=3D"">Modified Files:<br =
class=3D""><span class=3D"Apple-tab-span" style=3D"white-space: pre;"> =
</span>src/common/lib/libc/arch/arm/atomic: atomic_nand_16.S =
atomic_nand_32.S<br class=3D""><span class=3D"Apple-tab-span" =
style=3D"white-space: pre;"> =
</span> atomic_nand_64.S atomic_nand_8.S =
sync_fetch_and_nand_8.S<br class=3D""><br class=3D"">Log Message:<br =
class=3D"">Use gcc 4.4 and later operation for nand, i.e.<br =
class=3D"">*ptr =3D ~(tmp & value) instead of *ptr =3D ~tmp & =
value<br class=3D""><br class=3D"">There was also another bug in =
sync_fetch_and_nand_8 which I've also fixed.<br class=3D""><br =
class=3D"">PR port-arm32/50513: Incorrect logic for atomic_nand_xx.S<br =
class=3D""><br class=3D""><br class=3D"">To generate a diff of this =
commit:<br class=3D"">cvs rdiff -u -r1.2 -r1.3 =
src/common/lib/libc/arch/arm/atomic/atomic_nand_16.S \<br =
class=3D""> src/common/lib/libc/arch/arm/atomic/ato=
mic_nand_32.S \<br =
class=3D""> src/common/lib/libc/arch/arm/atomic/ato=
mic_nand_8.S<br class=3D"">cvs rdiff -u -r1.3 -r1.4 =
src/common/lib/libc/arch/arm/atomic/atomic_nand_64.S<br class=3D"">cvs =
rdiff -u -r1.4 -r1.5 \<br =
class=3D""> src/common/lib/libc/arch/arm/atomic/syn=
c_fetch_and_nand_8.S<br class=3D""><br class=3D"">Please note that diffs =
are not public domain; they are subject to the<br class=3D"">copyright =
notices on the relevant files.</div><div class=3D""><br =
class=3D""><div><blockquote type=3D"cite" class=3D""><div class=3D"">On =
May 29, 2016, at 11:13 PM, <a href=3D"mailto:dholland%NetBSD.org@localhost"; =
class=3D"">dholland%NetBSD.org@localhost</a> wrote:</div><br =
class=3D"Apple-interchange-newline"><div class=3D"">Synopsis: Incorrect =
logic for atomic_nand_xx.S<br class=3D""><br =
class=3D"">State-Changed-From-To: open->feedback<br =
class=3D"">State-Changed-By: <a href=3D"mailto:dholland%NetBSD.org@localhost"; =
class=3D"">dholland%NetBSD.org@localhost</a><br class=3D"">State-Changed-When: =
Mon, 30 May 2016 04:13:34 +0000<br class=3D"">State-Changed-Why:<br =
class=3D"">Is this fixed?<br class=3D""><br class=3D""><br class=3D""><br =
class=3D""></div></blockquote></div><br class=3D""></div></body></html>=
--Apple-Mail=_34BE15E0-BA3E-4DAF-BCEF-9694CFA90729--
Home |
Main Index |
Thread Index |
Old Index