NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: port-arm32/50513 (Incorrect logic for atomic_nand_xx.S)



Yes,

Fix committed by Nick Hudson, 12/11/2015. See below.

Frank

From: "Nick Hudson" <skrll%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/50513 CVS commit: src/common/lib/libc/arch/arm/atomic
Date: Fri, 11 Dec 2015 12:41:10 +0000

Module Name: src
Committed By: skrll
Date: Fri Dec 11 12:41:10 UTC 2015

Modified Files:
src/common/lib/libc/arch/arm/atomic: atomic_nand_16.S atomic_nand_32.S
    atomic_nand_64.S atomic_nand_8.S sync_fetch_and_nand_8.S

Log Message:
Use gcc 4.4 and later operation for nand, i.e.
*ptr = ~(tmp & value) instead of *ptr = ~tmp & value

There was also another bug in sync_fetch_and_nand_8 which I've also fixed.

PR port-arm32/50513: Incorrect logic for atomic_nand_xx.S


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/common/lib/libc/arch/arm/atomic/atomic_nand_16.S \
    src/common/lib/libc/arch/arm/atomic/atomic_nand_32.S \
    src/common/lib/libc/arch/arm/atomic/atomic_nand_8.S
cvs rdiff -u -r1.3 -r1.4 src/common/lib/libc/arch/arm/atomic/atomic_nand_64.S
cvs rdiff -u -r1.4 -r1.5 \
    src/common/lib/libc/arch/arm/atomic/sync_fetch_and_nand_8.S

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

On May 29, 2016, at 11:13 PM, dholland%NetBSD.org@localhost wrote:

Synopsis: Incorrect logic for atomic_nand_xx.S

State-Changed-From-To: open->feedback
State-Changed-By: dholland%NetBSD.org@localhost
State-Changed-When: Mon, 30 May 2016 04:13:34 +0000
State-Changed-Why:
Is this fixed?






Home | Main Index | Thread Index | Old Index