kern/50230: conflict in type declaration of 'idtype_t' from sys/types.h with POSIX sys/wait.h

[Heiko%hexco.de@localhost]

>Number:         50230
>Category:       kern
>Synopsis:       conflict in type declaration of 'idtype_t' from sys/types.h with POSIX sys/wait.h
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 11 08:00:00 +0000 2015
>Originator:     Heiko Eißfeldt
>Release:        NetBSD7.0 RC3 amd64
>Organization:
>Environment:
VirtualBox 5.0 on Ubuntu 14.04 LTS amd64 running stock NetBSD7.0-RC3 amd64 install
>Description:
Hello dear NetBSD people,

during compilation of schilytools I found an incompatibility/conflict in the type declaration of 'idtype_t'.

The declaration of type 'idtype_t' in NetBSD in sys/types.h is:

typedef int idtype_t;

while the declaration according to POSIX is in sys/wait.h and has a different meaning.

Quote from POSIX documentation (see http://pubs.opengroup.org/onlinepubs/007904975/basedefs/sys/wait.h.html):
The type idtype_t shall be defined as an enumeration type whose possible values shall include at least the following: P_ALL P_PID P_PGID

End quote

Please note that sys/wait.h unfortunately also includes sys/types.h.
>How-To-Repeat:
I tried to compile the program suite schilytools
(http://sourceforge.net/projects/schilytools/files/schily-2015-09-03.tar.bz2/download)
with NetBSD_7.0RC3 amd64. The compilation of 'osh' failed with undeclared identifiers 'P_ALL', 'P_PID', and 'P_PGID'.
(I used the script psmake/MAKE-all to compile the whole suite).

Schilytools has an autoconf test for type idtype_t, but certainly did not expect a conflicting declaration.

>Fix:
suggestion: rename NetBSD's type 'idtype_t' to something more special.