Re: lib/49653: tests/lib/libc/gen/t_siginfo:sigbus_adraln failed on m68k

[Tetsuya Isaki <isaki%pastel-flower.jp@localhost>]

The following reply was made to PR lib/49653; it has been noted by GNATS.

From: Tetsuya Isaki <isaki%pastel-flower.jp@localhost>
To: Martin Husemann <martin%duskware.de@localhost>, gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: lib/49653: tests/lib/libc/gen/t_siginfo:sigbus_adraln failed on m68k
Date: Sun, 15 Feb 2015 16:35:41 +0900

 At Sat, 14 Feb 2015 15:08:14 +0100,
 Martin Husemann wrote:
 > >  But the sun2 compiler (at least the slightly dated version I happen
 > >  to have around) still defines __m68k__ as 1.
 > 
 > But I see your point: if it is statically restricted to a sun2 vs. other
 > m68k ports, doing it with a simple #ifdef should be ok. Something like
 > 
 > #if defined(__m68k__) && !defined(__mc68000__) && !defined(__mc68010__)
 >    atf_tc_skip(...)
 > #endif
 > 
 > should work.
 
 Thank you for understanding what I want to say.
 But both of m68k and sun2 seems define __mc68000__ (though
 I understand your intention of __mc68000__).
 
 % /var/obj/current/x68k/tools/bin/m68k--netbsdelf-gcc -dM -E t_siginfo.c | grep -e 'm.\?68' | sort
 #define __m68k__ 1
 #define __mc68000 1
 #define __mc68000__ 1
 #define __mc68020 1
 #define __mc68020__ 1
 #define mc68000 1
 #define mc68020 1
 
 % /var/obj/current/news68k/tools/bin/m68k--netbsdelf-gcc -dM -E t_siginfo.c | grep -e 'm.\?68' | sort
 #define __m68k__ 1
 #define __mc68000 1
 #define __mc68000__ 1
 #define __mc68020 1
 #define __mc68020__ 1
 #define mc68000 1
 #define mc68020 1
 
 % /var/obj/current/sun2/tools/bin/m68010--netbsdelf-gcc -dM -E t_siginfo.c | grep -e 'm.\?68' | sort
 #define __m68k__ 1
 #define __mc68000 1
 #define __mc68000__ 1
 #define __mc68010 1
 #define __mc68010__ 1
 #define mc68000 1
 #define mc68010 1
 
 
 So how about this again?
 
 Index: tests/lib/libc/gen/t_siginfo.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/gen/t_siginfo.c,v
 retrieving revision 1.28
 diff -u -r1.28 t_siginfo.c
 --- tests/lib/libc/gen/t_siginfo.c	13 Feb 2015 16:56:57 -0000	1.28
 +++ tests/lib/libc/gen/t_siginfo.c	15 Feb 2015 06:40:07 -0000
 @@ -465,6 +465,10 @@
  	if (val == 0)
  		atf_tc_skip("No SIGBUS signal for unaligned accesses");
  #endif
 +#if defined(__m68k__) && !defined(__mc68010__)
 +	/* m68k except sun2 (i.e. >=68020) never issue SIGBUS (PR lib/49653) */
 +	atf_tc_skip("No SIGBUS signal for unaligned accesses");
 +#endif
  
  	sa.sa_flags = SA_SIGINFO;
  	sa.sa_sigaction = sigbus_action;
 
 ---
 Tetsuya Isaki <isaki%pastel-flower.jp@localhost / isaki%NetBSD.org@localhost>