NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PR/48710 CVS commit: src/sys/arch/arm/arm

The following reply was made to PR port-arm/48710; it has been noted by GNATS.

From: "Matt Thomas" <>
Subject: PR/48710 CVS commit: src/sys/arch/arm/arm
Date: Thu, 10 Apr 2014 02:55:13 +0000

 Module Name:   src
 Committed By:  matt
 Date:          Thu Apr 10 02:55:13 UTC 2014
 Modified Files:
        src/sys/arch/arm/arm: cpufunc_asm_armv7.S
 Log Message:
 Address PR/48710.
 r3 is not trashed during the routine so the level is preserved.
 The only two real bugs was not initializing r3 to 0 to start with L1 cache
 and the invalid fetching the set count from r3.  The mov r1, #0 should have
 been mov r3, #0 and has been corrected.
 Instead of two shifts, just use ubfx to extract the set bits and then compare
 them to 0.
 Add some other minor optimizations that make the code a little clearer.
 To generate a diff of this commit:
 cvs rdiff -u -r1.16 -r1.17 src/sys/arch/arm/arm/cpufunc_asm_armv7.S
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home | Main Index | Thread Index | Old Index