Re: kern/11018 (VIA VT83C572 UHCI USB controller does not work)

[Nick Hudson <skrll%netbsd.org@localhost>]

The following reply was made to PR kern/11018; it has been noted by GNATS.

From: Nick Hudson <skrll%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>, 
kern-bug-people%netbsd.org@localhost, 
 gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/11018 (VIA VT83C572 UHCI USB controller does not work)
Date: Mon, 14 Oct 2013 08:39:39 +0100

 This is a multi-part message in MIME format.
 --------------070801000702050805040906
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 On 10/13/13 17:45, Izumi Tsutsui wrote:
 > The following reply was made to PR kern/11018; it has been noted by GNATS.
 >
 > From: Izumi Tsutsui<tsutsui%ceres.dti.ne.jp@localhost>
 > To:skrll%netbsd.org@localhost
 > Cc:gnats-bugs%NetBSD.org@localhost,tsutsui%ceres.dti.ne.jp@localhost
 > Subject: Re: kern/11018 (VIA VT83C572 UHCI USB controller does not work)
 > Date: Mon, 14 Oct 2013 01:44:51 +0900
 >
 >   > I'd be interested if this diff helps your device
 >   >
 >   >http://www.netbsd.org/~skrll/usb.enum.diff
 >   
 >   Still gets device problem:
 >   
 >
 [snip]
 
 Can you try the attached patch on top of the existing diffs, please? It 
 still looks like we need to be careful with your device.
 
 >   Note a USB guy says that we need some delay even on the root hub here:
 >   http://nxr.netbsd.org/xref/src/sys/dev/usb/uhub.c?r=1.124#344
 >   (though adding a delay doesn't help this PR case)
 
 I'll take a look.
 
 >   > >   >> ../../../../dev/usb/uhci.c:863:1: error: 'uhci_dump_qhs' defined 
 > but not used
 >   
 >   > I think this is as simple as changing the uhci_dump_qh in uhci_dump_all
 >   > to uhci_dump_qhs
 >   
 >   Now this part seems fixed.
 
 Good news
 
 
 >   ---
 >   Izumi Tsutsui
 >   
 >
 
 Nick
 
 --------------070801000702050805040906
 Content-Type: text/plain; charset=us-ascii;
  name="uhci.c.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="uhci.c.diff"
 
 Index: sys/dev/usb/uhci.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/usb/uhci.c,v
 retrieving revision 1.261
 diff -u -p -u -r1.261 uhci.c
 --- sys/dev/usb/uhci.c 29 Sep 2013 07:28:20 -0000      1.261
 +++ sys/dev/usb/uhci.c 14 Oct 2013 07:36:25 -0000
 @@ -1986,7 +1987,7 @@ uhci_alloc_std_chain(struct uhci_pipe *u
                        return (USBD_NOMEM);
                }
                p->link.std = lastp;
 -              p->td.td_link = htole32(lastlink | UHCI_PTR_VF | UHCI_PTR_TD);
 +              p->td.td_link = htole32(lastlink /* | UHCI_PTR_VF */ | 
UHCI_PTR_TD);
                lastp = p;
                lastlink = p->physaddr;
                p->td.td_status = htole32(status);
 
 
 --------------070801000702050805040906--