Re: bin/48195: wrong position of __MKTEMP_OK__ in src/usr.bin/xinstall.c

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR bin/48195; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: bin/48195: wrong position of __MKTEMP_OK__ in
 src/usr.bin/xinstall.c
Date: Sun, 6 Oct 2013 09:23:05 +0000

 On Mon, Sep 09, 2013 at 03:30:00AM +0000, hsuenaga%iij.ad.jp@localhost wrote:
  > __MKTEMP_OK__ should be defined before include "nbtool_config.h."
  > otherwise tools-compiler print warning message of "mktemp()
  > possibly used unsafely, use mkstemp() or mkdtemp()." for the reason
  > that nbtool_config.h declares mktemp() in stdlib.h. (at least x86)
 
 Maybe it would be better to fix xinstall to not use mktemp; eventually
 we'll need a (different) version of the __MKTEMP_OK__ workaround for
 every build host OS.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost