Re: kern/46291: fxp crash

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR kern/46291; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: Aleksey Cheusov <cheusov%tut.by@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: kern/46291: fxp crash
Date: Tue, 8 May 2012 12:00:45 +0200

 --PmA2V3Z32TCmWXqI
 Content-Type: text/plain; charset=iso-8859-1
 Content-Disposition: inline
 Content-Transfer-Encoding: 8bit
 
 On Tue, May 08, 2012 at 12:49:54PM +0300, Aleksey Cheusov wrote:
 > This crash happened during reboot process, emmidiately after reboot(8),
 > not while booting.
 
 Ok, so the patch would not help.
 
 > >  Does fxp share the interrupt  with something else on your machine?
 > 
 > How can I check this? What command? BIOS settings?
 
 dmesg output would be a good start.
 
 Here is another patch for a similar race in case of shared interrupts
 during detach.
 
 Martin
 
 --PmA2V3Z32TCmWXqI
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch
 
 Index: i82557.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/ic/i82557.c,v
 retrieving revision 1.139
 diff -u -r1.139 i82557.c
 --- i82557.c   2 Feb 2012 19:43:03 -0000       1.139
 +++ i82557.c   8 May 2012 10:01:52 -0000
 @@ -2507,6 +2507,9 @@
        fxp_stop(ifp, 1);
        splx(s);
  
 +      /* make sure the interrupt handler bails quickly */
 +      sc->sc_enabled = 0;
 +
        /* Destroy our callout. */
        callout_destroy(&sc->sc_callout);
  
 
 --PmA2V3Z32TCmWXqI--