[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/45935: Requested change to comments in sys/param.h
The following reply was made to PR kern/45935; it has been noted by GNATS.
From: Alan Barrett <apb%cequrux.com@localhost>
Subject: Re: kern/45935: Requested change to comments in sys/param.h
Date: Mon, 6 Feb 2012 19:50:32 +0200
On Mon, 06 Feb 2012, kre%munnari.OZ.AU@localhost wrote:
> Hence, I am proposing some rules that seem to match the way the
> macro has been used in the (relatively) recent past - that is,
> no-one cases about 1.6ZA any more, and I supply here a patch to
> param.h that documents, in comments (the patch is almost exclusively
> to comments) my suggested rules.
> Note: this patch also removes __NetBSD_Prereq__()
I'd prefer to leave that for a separate change.
> I'd actually like to change the definition of __NetBSD_Version__
> to be (with appropriate numbers in place of M m and p of course):
> #define __NetBSD_Version__ (__NetBSD_VersID__(M,m,p)) /* cmt */
I like that, but will scripts that search for the comment be able to
>+ * 0 <= M < 42 (by the time this is a problem, the restriction will go)
>+ * 0 <= m <= 99
>+ * r = 0 (field not currently used)
>+ * m == 99 ? 0 <= p <= 9999 : 0 <= p <= 99
>+ * 0 <= z <= 99
Only two digits are reserved for "pp", so I think it should
be restricted to [0..99]. Alternatively, remove "rr", and
let "pppp" be 4 digits.
--apb (Alan Barrett)
Main Index |
Thread Index |