NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/43573: ffs superblock search prevents mounting tiny file systems



The following reply was made to PR kern/43573; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/43573: ffs superblock search prevents mounting tiny file
        systems
Date: Mon, 5 Jul 2010 19:36:10 +0000

 On Mon, Jul 05, 2010 at 05:05:00PM +0000, pooka%iki.fi@localhost wrote:
  > maybe this, although I haven't done any critical thinking about it.
  > 
  > [...]
  >                 if (error) {
  > -                       fs = NULL;
  > -                       goto out;
  > +                       continue;
  >                 }
 
 That should at least test for the expected error code... but wouldn't
 it be a better plan to check the block number against the volume size?
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost
 


Home | Main Index | Thread Index | Old Index