Re: kern/39094 (Add et (Agere ET1310/ET1301) network driver to NetBSD)

[Kaspar Brand <netbsd+gnats%velox.ch@localhost>]

The following reply was made to PR kern/39094; it has been noted by GNATS.

From: Kaspar Brand <netbsd+gnats%velox.ch@localhost>
To: gnats-bugs%NetBSD.org@localhost, John Nemeth <jnemeth%NetBSD.org@localhost>
Cc: 
Subject: Re: kern/39094 (Add et (Agere ET1310/ET1301) network driver to NetBSD)
Date: Sat, 20 Feb 2010 13:25:31 +0100

 This is a multi-part message in MIME format.
 --------------060501060502050505040600
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 John, can I help with any additional things here? I would definitely be
 glad to see this driver committed to the tree.
 
 For the sake of completeness, I'm also attaching an additional patch
 which I put together in January 2009, based on a suggestion from you
 (let ether_ioctl handle some more ioctls).
 
 I have been running this driver in NetBSD 5 since May 2009 (with the
 ioctl changes), and never experienced any problems with that device so far.
 
 --------------060501060502050505040600
 Content-Type: text/plain;
  name="if_et-ioctl.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="if_et-ioctl.diff"
 
 --- if_et.c.orig       2009-01-21 17:03:08.000000000 +0100
 +++ if_et.c    2009-01-21 17:10:58.000000000 +0100
 @@ -1035,21 +1035,6 @@
        s = splnet();
  
        switch (cmd) {
 -      case SIOCSIFADDR:
 -              ifp->if_flags |= IFF_UP;
 -              if (!(ifp->if_flags & IFF_RUNNING))
 -                      et_init(ifp);
 -#ifdef INET
 -              if (ifa->ifa_addr->sa_family == AF_INET)
 -                      arp_ifinit(ifp, ifa);
 -#endif
 -              break;
 -      case SIOCSIFMTU:
 -              if (ifr->ifr_mtu < ETHERMIN || ifr->ifr_mtu > ETHERMTU)
 -                      error = EINVAL;
 -              else if ((error = ifioctl_common(ifp, cmd, data)) == ENETRESET)
 -                      error = 0;
 -              break;
        case SIOCSIFFLAGS:
                if (ifp->if_flags & IFF_UP) {
                        /*
 @@ -1071,14 +1056,6 @@
                }
                sc->sc_if_flags = ifp->if_flags;
                break;
 -      case SIOCADDMULTI:
 -      case SIOCDELMULTI:
 -              if ((error = ether_ioctl(ifp, cmd, data)) == ENETRESET) {
 -                      if (ifp->if_flags & IFF_RUNNING)
 -                              et_setmulti(sc);
 -                      error = 0;
 -              }
 -              break;
        case SIOCSIFMEDIA:
        case SIOCGIFMEDIA:
                error = ifmedia_ioctl(ifp, ifr, &sc->sc_miibus.mii_media, cmd);
 
 --------------060501060502050505040600--