[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/42573: DIRBLKSIZ in <ufs/ufs/dir.h> should not beDEV_BSIZE constant
On Mon, Jan 04, 2010 at 02:34:27AM +0900, Izumi Tsutsui wrote:
> > At this rate you're going to have non-512-byte volumes working soon :-)
> Well, I'm afraid there are much more other problems around
> DEV_BSIZE (and DEV_BSHIFT) constant.
True. But you've been making a lot of progress...
> Probably we should nuke them from <machine/param.h>.
> - there are many btodb() and dbtob() (which uses DEV_BSHIFT) under sys/ufs
> - some disklabel sources (MD disksubr.c etc) use DEV_BSIZE to calculate
> offsets in several places (and lp->d_secsize is used in other places)
> - etc. etc.
These are the related old PRs that I've found so far (some have
patches, of varying quality):
2404 2895 3790 3791 3792 7668 18482 20934 25108 26634 32321 38171
David A. Holland
Main Index |
Thread Index |