NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/42573: DIRBLKSIZ in <ufs/ufs/dir.h> should not beDEV_BSIZE constant

>  At this rate you're going to have non-512-byte volumes working soon :-)

Well, I'm afraid there are much more other problems around
DEV_BSIZE (and DEV_BSHIFT) constant.
Probably we should nuke them from <machine/param.h>.

- there are many btodb() and dbtob() (which uses DEV_BSHIFT) under sys/ufs
- some disklabel sources (MD disksubr.c etc) use DEV_BSIZE to calculate
  offsets in several places (and lp->d_secsize is used in other places)
- etc. etc.

Izumi Tsutsui

Home | Main Index | Thread Index | Old Index