[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/41918: pppoe BROKEN: panic:kernel diagnostic assertion "!cpu_softintr_p()" ... subr_kmem.c
The following reply was made to PR kern/41918; it has been noted by GNATS.
From: Martin Husemann <martin%duskware.de@localhost>
Subject: Re: kern/41918: pppoe BROKEN: panic:kernel diagnostic assertion
"!cpu_softintr_p()" ... subr_kmem.c
Date: Sun, 23 Aug 2009 00:32:58 +0200
On Sat, Aug 22, 2009 at 11:40:00AM +0000, kardel%pip.acrys.com@localhost wrote:
> The violation of calling kmem_zalloc() (likely in
> in6_ifaddrs_schedule()) from a softint seems clear.
> Possibly pppoe shouldn't call in6_ifattach from softint.
Pppoe does not call in6_ifattach, but if_up().
I don't see why this should not be allowed from a softint (so IMHO the upper
layers should be fixed instead), but if we decide it isn't allowed to do so,
we could move it to a full thread context, though I don't like that either.
The way IFF_UP is used in this code certainly is ... uhm ... "creative",
so completely reworking it is worth considering, but not as simple
a task at it looks at first glance.
Main Index |
Thread Index |