[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/38791 (routing socket event header not cleared)
The following reply was made to PR kern/38791; it has been noted by GNATS.
From: jtc%acorntoolworks.com@localhost (J.T. Conklin)
Cc: kern-bug-people%NetBSD.org@localhost, netbsd-bugs%NetBSD.org@localhost,
Subject: Re: kern/38791 (routing socket event header not cleared)
Date: Mon, 02 Jun 2008 12:05:16 -0700
> Synopsis: routing socket event header not cleared
> State-Changed-From-To: closed->open
> State-Changed-By: mlelstv%NetBSD.org@localhost
> State-Changed-When: Sun, 01 Jun 2008 16:51:01 +0000
> The patch erases the whole message. Maybe clearing sizeof(rtm) is enough?
True, however this is essentially the same thing that callers to rt_msg2()
do (to they structure they pass) when they build a route event. Clearing
the whole message could conceivably fix problems where not all the event/
message payload data is being being zeroed too (althought this may not be
The total length of these messages are quite small, so any the extra cost
to zero the whole event should be similarly small.
Main Index |
Thread Index |