ATF-devel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/tests/lib/libc/ssp (fwd)



On Mon, Dec 27, 2010 at 9:30 PM, Paul Goyette <paul%whooppee.com@localhost> 
wrote:
[...]
> I _could_ use two separate functions, h_fail() and h_fail_echo() but didn't
> really want to duplicate things.  (I'd also need two separate h_pass() and
> h_pass_echo() functions...)
>
> Hmm, I guess I probably could use
>
>        echo "$2" | atf_check ...
>
> which would provide an empty line for stdin if $2 is empty.  It should not
> hurt anything.
>
> Either way, I'm not sure it makes much difference.

Aha, understood.  Then yes, it's probably OK to leave it as it is.

>> Mea culpa.  The SIGABRT name was not defined in atf-sh/atf-check.cpp.
>> I've added support for this upstream; would you like the change pulled
>> up to NetBSD also?  It's a one-liner.
>
> It would be nice to pull this up when you get a chance.  No hurry.

Done.

-- 
Julio Merino


Home | Main Index | Thread Index | Old Index