Re: Xorg 1.20 1bpp server performance regression and possible fixes

[David Brownlee <abs%absd.org@localhost>]

On Wed, 19 Apr 2023 at 17:08, Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost> wrote:
>
> I wrote (about two years ago):
>
> > > > > 1) Revert the whole commit as is (and put back fbtile.c to SRCS.fb
> > > > >    in src/external/mit/xorg/server/xorg-server/fb/Makefile.fb)
> > > > >
> > > > > 2) Put back the "fbEvenTile" and old "fbTile" to switch
> > > > >    "fbOddTile" (which is same as current fbTile) or "fbEvenTile"
> > > > >    into existing fb/fbfill.c as inline functions, to make
> > > > >    future import/merge less confusing
> > > > >
> > > > > 3) Ask xorg upstream to revert the change
> > > > >
> > > > > Of course the best way is 3) and 1), but I'm afread most people
> > > > > don't think it's worth to keep and maintain extra code for obsolete
> > > > > monochrome (and some 8bpp) servers and retro-computing geeks.
> > > >
> > > > i don't have a particular opinion about #1 or #1 so please
> > > > do what you feel is best.
> > >
> > > (I guess you meant #1 or #2 here)
> > > Ok, I'll commit as #1 (reverting changes) soon and send a pullup
> > > request to netbsd-9.
> >
> > #1 is also committed.
> >  https://mail-index.netbsd.org/source-changes/2020/08/09/msg120399.html
> >  https://mail-index.netbsd.org/source-changes/2020/08/09/msg120400.html
>
> Finally merged into xorg/server upstream:
>  https://gitlab.freedesktop.org/xorg/xserver/-/commit/7b1758936bd644020a560f2739ad7a50fbb87b17

Nice :) Thanks for not letting go!

David