Re: Building legacy DRM drivers on -current, and the fallout

[christos%astron.com@localhost (Christos Zoulas)]

In article <04ce376c-ff86-577c-b9ba-b6354b70152c%spg.tu-darmstadt.de@localhost>,
Hauke Fath  <hf%spg.tu-darmstadt.de@localhost> wrote:
>-=-=-=-=-=-
>
>All,
>
>I need to build a kernel for a Thinkpad T23, which sports an S3 Savage.
>
>Enabling the legacy DRM drivers on -current (and disabling the DRMKMS 
>ones) leads to fall-out for r128drm(4) and savagedrm(4):
>
>
>#   compile  T23/r128_cce.o
>/u/netbsd-builds/developer/i386/tools/bin/i486--netbsdelf-gcc 
>-msoft-float -mno-mmx -mno-sse -mno-avx -mindirect-branch=thunk 
>-mindirect-branch-register -ffreestanding -fno-zero-initialized-in-bss 
>-fno-delete-null-pointer-checks
>/public/netbsd-developer/sys/external/bsd/drm/dist/shared-core/r128_cce.c: 
>In function 'r128_do_init_cce':
>/public/netbsd-developer/sys/external/bsd/drm/dist/shared-core/r128_cce.c:415:2:
>
>error: case label does not reduce to an integer constant
>   case R128_PM4_64BM_64VCBM_64INDBM:
>   ^~~~
>/public/netbsd-developer/sys/external/bsd/drm/dist/shared-core/r128_cce.c:416:2:
>
>error: case label does not reduce to an integer constant
>   case R128_PM4_64PIO_64VCPIO_64INDPIO:
>   ^~~~
>
>*** Failed target:  r128_cce.o
>
>% /<8>dist/shared-core > egrep 
>'R128_PM4_64BM_64VCBM_64INDBM|R128_PM4_64PIO_64VCPIO_64INDPIO' *
>r128_cce.c:         (init->cce_mode != R128_PM4_64BM_64VCBM_64INDBM)) {
>r128_cce.c:     case R128_PM4_64BM_64VCBM_64INDBM:
>r128_cce.c:     case R128_PM4_64PIO_64VCPIO_64INDPIO:
>r128_drv.h:#    define R128_PM4_64BM_64VCBM_64INDBM     (8  << 28)
>r128_drv.h:#    define R128_PM4_64PIO_64VCPIO_64INDPIO  (15 << 28)
>%
>
>-- These look constant to me, and of integer type, so I am not sure what 
>gcc is trying to flag here, and what to do about it.

Perhaps it needs ULL?

>"savage_state.c", OTOH, triggered several "warning: this statement may 
>fall through [-Wimplicit-fallthrough=]". The attached patch deals with 
>that - the flagged fallthroughs look legit to me.
>
>Okay to commit?

Sure.

christos