Re: Fix for kern/54274: firmware loading issue in nouveau driver

[Thomas Klausner <tk%giga.or.at@localhost>]

On Thu, Jul 04, 2019 at 05:00:00AM +1000, Matthew Green wrote:
> > I've remodeled the nouveau attach routine to match the one used by the
> > radeon driver, to address PR 54274.
> > 
> > The attached diff changes the dmesg output like this (and moves all
> > the nouveau lines around because most of the attachment happens much
> > later):
> > 
> > Before you ask: All of the line reordering changes are because the
> > radeon driver (radeon_pci.c) does it in that order, and I didn't
> > change style stuff I found weird to make the two drivers match up as
> > closely as possible.
> > 
> > Ok to commit?
> 
> i think you can avoid the "goto out;" part by simply moving
> the assignment to sc_dev to the start of the new
> nouveau_pci_attach_real().  ie, make it happen always so that
> existing return paths remain valid..
> 
> either way, LGTM.

Thanks for the review!
I've changed it as suggested and committed it.
 Thomas