Re: prep (and bebox) xserver support

[Bernd Ernesti <netbsd%lists.veego.de@localhost>]

Hi Takashi,

On Thu, Jul 08, 2010 at 03:14:00PM +0900, KIYOHARA Takashi wrote:
> Hi! Bernd,
> 
> 
> From: Bernd Ernesti <netbsd%lists.veego.de@localhost>
> Date: Wed, 7 Jul 2010 22:20:25 +0200
> 
> > On Wed, Jul 07, 2010 at 03:19:09PM +0900, KIYOHARA Takashi wrote:
> > > Hi! Matthew and Michael
> 
> > > @@ -142,13 +144,15 @@
> > >  
> > >  
> > >  static PciChipsets S3PciChipsets[] = {
> > > + { PCI_CHIP_864_0,       PCI_CHIP_864_0,         RES_SHARED_VGA },
> > > + { PCI_CHIP_864_1,       PCI_CHIP_864_1,         RES_SHARED_VGA },
> > >   { PCI_CHIP_964_0,       PCI_CHIP_964_0,         RES_SHARED_VGA },
> > >   { PCI_CHIP_964_1,       PCI_CHIP_964_1,         RES_SHARED_VGA },
> > > - { PCI_CHIP_968,         PCI_CHIP_968,           RES_SHARED_VGA },
> > > - { PCI_CHIP_TRIO,        PCI_CHIP_TRIO,          RES_SHARED_VGA },
> > > - { PCI_CHIP_AURORA64VP,  PCI_CHIP_AURORA64VP,    RES_SHARED_VGA },
> > > - { PCI_CHIP_TRIO64UVP,   PCI_CHIP_TRIO64UVP,     RES_SHARED_VGA },
> > > - { PCI_CHIP_TRIO64V2_DXGX,       PCI_CHIP_TRIO64V2_DXGX,         
> > > RES_SHARED_VGA },
> > > + { PCI_CHIP_968,         PCI_CHIP_968,           RES_SHARED_VGA },
> > > + { PCI_CHIP_TRIO,        PCI_CHIP_TRIO,          RES_SHARED_VGA },
> > > + { PCI_CHIP_AURORA64VP,  PCI_CHIP_AURORA64VP,    RES_SHARED_VGA },
> > > + { PCI_CHIP_TRIO64UVP,   PCI_CHIP_TRIO64UVP,     RES_SHARED_VGA },
> > > + { PCI_CHIP_TRIO64V2_DXGX, PCI_CHIP_TRIO64V2_DXGX, RES_SHARED_VGA },
> > >   { -1,                   -1,                     RES_UNDEFINED }
> > >  };
> > 
> > Can you only add the two new lines and not change the other lines in this 
> > part?
> 
> Oops, please fix white-spaces these 5-lines beforehand.  ;-)

The reason why I asked is to make sure we do not modify more then what
is needed to keep the changes to a minimum.

> > > @@ -609,6 +615,54 @@
> > >   pScrn->rgbBits = 8;     /* set default */
> > >  
> > >   /* probe for dac */
> > > + if (S3GENDACProbe(pScrn)) {
> > > +         pS3->DacPreInit = S3GENDAC_PreInit;
> > > +         pS3->DacSave = S3GENDAC_Save;
> > > +         pS3->DacRestore = S3GENDAC_Restore;
> > > +         if (pS3->RamDac->RamDacType == GENDAC_RAMDAC) {
> > > +                 pS3->DacInit = S3GENDAC_Init;
> > > +                 switch(pScrn->bitsPerPixel) {
> > > +                 case 8:
> > > +#if 0
> > > +                         pS3->MaxClock = 110000;
> > > +#else
> > > +                         pS3->MaxClock = 95000;
> > > +#endif
> > 
> > What is the reason you are not using 110000 or 55000 further down?
> > I would remove the three #if 0 parts.
> > Maybe add a note that the MaxClock is reduced and what it should be.
> 
> hmm...
> I also lost this reason.  In my memory, I think that the source of the
> old GENDAC support to which I referred did like this.
> I can remove between #if 0 - #else.  However I have not notes...

Ok. I know that it is possible to overclock some chip. Maybe that
was the reason behind the if 0 parts.

Bernd