Re: s3_drv of xorg

[KIYOHARA Takashi <kiyohara%kk.iij4u.or.jp@localhost>]

Hi! all,


I do the supplementation explanation of this problem.

From: KIYOHARA Takashi <kiyohara%kk.iij4u.or.jp@localhost>
Date: Mon, 15 Dec 2008 02:42:45 +0900 (JST)

> Hi! all,
> 
> 
> From: KIYOHARA Takashi <kiyohara%kk.iij4u.or.jp@localhost>
> Date: Wed, 10 Dec 2008 01:12:56 +0900 (JST)
> 
> > the s3 was not included in SRCS though s3_accel.c was necessary.
> > Moreover, s3_accel.c has a lot of ugly codes in which '#ifdef S3_NEWMMIO'
> > is done.  This will not be able to support Trio64/964(older) and Trio64V2/
> > 968(newmmio) at the same time perhaps.  bebox use Trio64.
> 
> I made this patches.
> My machine(bebox) works with S3 Trio64.  Can you test with Trio64V2 or 968?

I loaded s3_drv.so first.  The X server crashed immediately after that and
keep the black screen.  I could login by ssh.  The cause was uncertain
though I had seen Xorg.0.log.

However, I saw the following message in typescript in executing startx(1)
via script(1).


(EE) s3(0): Cannot read V_BIOS (5)
(II) Module "ramdac" already built-in
/usr/X11R7/lib/modules/drivers//s3_drv.so: Undefined PLT symbol 
"S3AccelInitPIO" (symnum = 51)
X connection to :0.0 broken (explicit kill or server shutdown).^M


The symbol S3AccelInitPIO is function in s3_accel.c.  However s3_accel.o
not found in ${MAKEOBJDIR}/external/mit/xorg/server/drivers/xf86-video-s3,
because not include s3_accel.c at SRCS.
And I look /usr/xsrc/external/mit/xf86-video-s3/dist/src/Makefile.am

#  tail -n 22 ../xsrc/external/mit/xf86-video-s3/dist/src/Makefile.am


s3_drv_la_SOURCES = \
         newmmio.h \
         s3_bios.c \
         s3_cursor.c \
         s3_dga.c \
         s3_driver.c \
         s3.h \
         s3_IBMRGB.c \
         s3_reg.h \
         s3_Ti.c \
         s3_Trio64DAC.c \
         s3_video.c

noinst_LTLIBRARIES = libs3_accel_newmmio.la libs3_accel_pio.la
s3_drv_la_LIBADD = libs3_accel_newmmio.la libs3_accel_pio.la

libs3_accel_newmmio_la_SOURCES = s3_accel.c
libs3_accel_newmmio_la_CFLAGS = $(AM_CFLAGS) -DS3_NEWMMIO=1

libs3_accel_pio_la_SOURCES = s3_accel.c
libs3_accel_pio_la_CFLAGS = $(AM_CFLAGS)


I think maybe need s3_accel.c.


Moreover, s3_accel.c supports only either of PIO or newmmio to me.
Therefore, I made the patch to support both.


By the way, I noticed.  Should s3 make the submodule like cirrus
cirrus_lagna and cirrus_alpine.  In this case, we create
external/mit/xorg/server/drivers/xf86-video-s3_{pio,newmmio}.  Also to
call xf86LoadDrvSubModule() in s3_driver.c.  The s3_driver.c doesn't
load the submodule now.

Have you any idea?

Thanks,
--
kiyohara