On Sat, Jan 03, 2004 at 07:24:59 +0300, Valeriy E. Ushakov wrote:

> > Modified Files:
> > 	xsrc/xfree/xc/programs/Xserver/hw/netbsd/hpc: hpcFB.c
> > 
> > Log Message:
> > Spell FORCE_SEPARATE_PRIVATE correctly.
> 
> Looking at the logic makes me wonder if Xhpc still works on hpcmips.
> as this spelling error should have caused CFB_NEED_SCREEN_PRIVATE to
> be undefined.
> 
> Also, I don't feel good about this redefinition trick, b/c it can
> potentially make hpcFB.c and cfb have different ideas about
> CFB_NEED_SCREEN_PRIVATE.  If that's ok, hpcFB.c at least deserves an
> explanatory comment to that effect.

Oh, my hpcsh cross-build of Xhpc just failed because of that.

/usr/nb/obj/hpcsh/x11/Xserver/hw/netbsd/hpc/libhpc.a(hpcFB.o)(.text+0x470): In function `hpc16ScreenInit':
/nb/xsrc/xfree/xc/programs/Xserver/hw/netbsd/hpc/hpcFB.c:200: undefined reference to `cfb16CreateScreenResources'
/usr/nb/obj/hpcsh/x11/Xserver/hw/netbsd/hpc/libhpc.a(hpcFB.o)(.text+0x474):/nb/xsrc/xfree/xc/programs/Xserver/hw/netbsd/hpc/hpcFB.c:200: undefined reference to `cfb16ScreenPrivateIndex'

Tyler's patches has -DFORCE_SEPARATE_PRIVATE in the Makefile.

But my cross-built Xhpc cored because the private was yanked from
under the code that expected it to be there (don't remember the
details).

SY, Uwe
-- 
uwe@ptc.spbu.ru                         |       Zu Grunde kommen
http://www.ptc.spbu.ru/~uwe/            |       Ist zu Grunde gehen