[PATCH] Remove useless warning from man(1)

["Olivier Duclos" <odc%sleepycat.fr@localhost>]

Hello,

I propose to remove the message "man: Formatting manual page..." that we get each time we call man.

I find it annoying. Surely I cannot be the only one? It is also an anti-pattern for a UNIX program to emit such a useless message during normal operation. For the large majority of users, manual page formatting is instantaneous. And for those who run NetBSD on very slow hardware, I bet they don't need to be reminded how man(1) works each time either.

diff --git i/usr.bin/man/man.c w/usr.bin/man/man.c
index 7d23e1d..0788bc6 100644
--- i/usr.bin/man/man.c
+++ w/usr.bin/man/man.c
@@ -749,19 +749,12 @@ fmtcheck_ok(const char *userfmt, const char *template)
 static void
 build_page(const char *fmt, char **pathp, struct manstate *mp)
 {
-       static int warned;
        int olddir, fd, n;
        size_t tmpdirlen;
        char *p, *b;
        char buf[MAXPATHLEN], cmd[MAXPATHLEN], tpath[MAXPATHLEN];
        const char *tmpdir;
 
-       /* Let the user know this may take awhile. */
-       if (!warned) {
-               warned = 1;
-               warnx("Formatting manual page...");
-       }
-
        /*
         * Historically man chdir'd to the root of the man tree.
         * This was used in man pages that contained relative ".so"

-- 
  Olivier Duclos