tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH 1/3] gcc: Add missing parentheses around ternary operator



On Sun, Aug 29, 2021 at 01:42:22PM +1000, Damien Zammit wrote:
> --- a/external/gpl3/gcc/dist/libcpp/files.c
> +++ b/external/gpl3/gcc/dist/libcpp/files.c
> @@ -233,7 +233,7 @@ open_file (_cpp_file *file)
>      }
>    else
>      file->fd = open (file->path, O_RDONLY | O_NOCTTY | O_BINARY
> -		     | (cpp_restricted != NULL) ? O_NONBLOCK : 0, 0666);
> +		     | ((cpp_restricted != NULL) ? O_NONBLOCK : 0), 0666);

This is something we would prfer to go via upstream gcc, has it been
reported there? If we bring in a temporary local fix, we usually note
a reference to the upstrem commit or bug report.

Martin


Home | Main Index | Thread Index | Old Index