| I did not plan to work on this in the first place, and I presented a better solution to provide compatibility. Nobody jumped on it, and I felt that I had to jump in and implement it before terminfo2 was cast in stone. The terminfo database before I cleaned it up was a mess. There was no build process, or explanation how to import it, or what the local changes where. It also took 4 months before we discovered the uint16_t field overflow. I didn't even know that there was a 16 bit limitation, so I could not have figured it out. I tested my changes (and tetris seemed to work but with different colors). But without unit-tests or a test procedure it is impossible to check all cases. In fact I introduced a bug Andreas found in sysinst for using the wrong variable. Your changes for uint32_t fields were also incomplete and caused memory corruption because you missed a place that needed changing. When we switched to cdb infocmp was not updated to eat the correct suffix. Recently you changed blacklistd without prior discussion and you introduced a security bug. The terminfo2 changes were not discussed either - I would have objected to creating yet another file to hold the compiled definitions. My apologies for you having to do more work cleaning this up, but that works both ways... christos
|
Attachment:
signature.asc
Description: Message signed with OpenPGP