Re: [PATCH] grep: fix ASan heap-buffer-overflow.

To: enh <enh%google.com@localhost>, "tech-userlevel%netbsd.org@localhost User-Level Technical" <tech-userlevel%netbsd.org@localhost>
Subject: Re: [PATCH] grep: fix ASan heap-buffer-overflow.
From: Kamil Rytarowski <n54%gmx.com@localhost>
Date: Sat, 30 Mar 2019 20:59:24 +0100

On 30.03.2019 06:12, enh wrote:
> Like the regular fgetln(), grep_fgetln() doesn't NUL-terminate the
> string, which regexec() doesn't like. ASan just gained the ability to
> intercept regexec(), which is why we didn't find this previously.
> 
> Bug: http://b/129089665
> Test: adb shell grep -R /system -e "abc"

Just for the record as interception, the regex(3) support (together with
a number of other APIs) was contributed to LLVM by The NetBSD Foundation.

Attachment: signature.asc
Description: OpenPGP digital signature

References:
- [PATCH] grep: fix ASan heap-buffer-overflow.
  - From: enh

Prev by Date: [PATCH] grep: fix ASan heap-buffer-overflow.
Next by Date: Re: [PATCH] grep: fix ASan heap-buffer-overflow.
Previous by Thread: [PATCH] grep: fix ASan heap-buffer-overflow.
Next by Thread: Re: [PATCH] grep: fix ASan heap-buffer-overflow.
Indexes:

Home | Main Index | Thread Index | Old Index