tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: varargs bug in libedit



In article <20151102223523.GD50561%spindle.one-eyed-alien.net@localhost>,
Brooks Davis  <brooks%freebsd.org@localhost> wrote:
>I've commmitted the following to FreeBSD's copy of libedit.  It fixes a
>bug in varargs handling in el_get().  It's harmless for most
>architectures, but our CHERI architecture turns it into a failure.

This looks wrong. To set let's say EL_SIGNAL you do:

	el_set(el, EL_SIGNAL, 1);

but how do you get the current setting of EL_SIGNAL if you pass an int?
You need:

	int x;
	el_get(el, EL_SIGNAL, &x);

Something else is wrong...

christos



Home | Main Index | Thread Index | Old Index