tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: reallocarr(3) cleanup



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 11.07.2015 16:25, Taylor R Campbell wrote:
> Date: Sat, 11 Jul 2015 15:18:31 +0200 From: Kamil Rytarowski
> <n54%gmx.com@localhost>
> 
> I noticed that I forgot to attach the patch.. 
> https://github.com/krytarowski/netbsd/commit/75c12bd4e1458485e585fab39
80
>
> 
f250fdb80329b
> 
> Prefer attaching the patch to your message so the mailing list
> archive keeps a copy of it for future reference.
> 
> I'm planning to commit on Monday (13 Jul) from it the following
> changes:
> 
> Separate commits, please!
> 

This is the way I will do it.

> - - add erallocarr(3) to libutil,
> 
> OK.
> 
> - - add missing Id tag to reallocarray.c,
> 
> Write `$NetBSD$'; `$NetBSD: $' doesn't work.
> 
> - - sync reallocarr prototype with documentation (num -> number),
> 
> OK.
> 
> - - reorder memcpy(3) and save errno -- for safety as memcpy(3)
> might change it.
> 
> OK, although I don't think there is any danger that anyone's
> memcpy might clobber errno.
> 

Thanks!

> I saw some other changes in the commit.  Please mention these in
> your email describing it!
> 

Sorry, I will cherry-pick only the mentioned parts from the original
(old) patch. The rest (man-pages) won't be applied. I should be more
clear on skipping the rest.

I would like to keep the history of NetBSD functions anyway. But
please leave it (along with man-page changes) for later.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVoShIAAoJEEuzCOmwLnZs3PwQAK0US0pHyv52BoONO8iihX+U
9mmbGhaWjFWr5zb4TAFBqCoE3HeUfjMz7a9Zb905/cWtog5OAvTSyfr3BVuty8aY
Av56g61X/XlW0IwaIemA3XTStas9LdbIPC1ZfUDr7U9qcD7Zmy2+vVCP262DNlpE
U84G2zW+JziXnnuaGBQo0GMyTGeIm/V3BPpXrfTw1RhVk+4PwwoIvtENu5Y6KFyR
9oyEXZz+LZjWuTJJfitWn5VGVRtdo4aLP/xwvhc/weov32N6P5GoqmJmjxRJJb3m
EUplNg0pdHPTRCIvi5JGSZA6kNMh9NJECKICQr+sQFKR0hzS+IhLcfe5aGT9ICKd
W5tcRRy9QgvAOaMdfH89aFcbsuN++/OVJoanP2HNGP3+UI8Yt79CsNq8e1Kibz9P
DDZ8Hhe8geDO28tsIMpM+PcGLq+jmwyuQvNVanCVzSzDv7EJYJhUjBpURW+UtzQp
2HyJ7RQbk2tcGHL6Ko4WfbZoofDX1BmK/GsJCxOWBTuyHXZcAEFjIzScBdPN3GOO
n8dx1m5lzF4RAauZW1/mzFXlSsLpJfv9VqdD8ITLg/oqtB3iPEPSTU8FcfnlSYYz
bEbJpXZweHljS8SLbaVhep4cvvajKeysZu2MNXvC+AsJiB8Q8ovKTgP+b2vcL1dq
VKFn0WXcWzqoH0JKbLfw
=TNWb
-----END PGP SIGNATURE-----


Home | Main Index | Thread Index | Old Index