Rumpification (was Re: CVS commit: src/usr.sbin/envstat)

[Simon Burge <simonb%NetBSD.org@localhost>]

"Antti Kantee" wrote:

> Module Name:  src
> Committed By: pooka
> Date:         Mon Dec 13 18:00:39 UTC 2010
> 
> Modified Files:
> 
>       src/usr.sbin/envstat: Makefile envstat.c
> Added Files:
> 
>       src/usr.sbin/envstat: envstat_hostops.c envstat_rumpops.c prog_ops.h
> 
> Log Message:
> 
> RUMP_ACTION -> RUMPPRG

This doesn't appear to be a very scalable or usable solution.  Lots
of nearly but not quite the same *hostops.c and *rumpops.c files are
appearing over the source tree.  Random syscalls now gain a prog_ prefix
which adds no readability to the code, for example:

-       (void)close(sysmonfd);
+       (void)prog_close(sysmonfd);

So now someone adding code to any RUMPPRG'd program now needs to
effectively check each syscall individually to see if it needs a prog_
wrapper?  What is the effect of a direct call to the original system
call, eg close() above, in these situations?  How will these changes be
audited/verified so that mistakes won't occur?

Was this change (including the scope of it) discussed anywhere before
you committed it?

Cheers,
Simon.