Re: pkgsrc RC scripts

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Mon, Oct 19, 2009 at 06:11:34AM +0100, Alistair Crooks wrote:
> On Sun, Oct 18, 2009 at 11:24:11PM -0400, Matthew Mondor wrote:
> > On Mon, 19 Oct 2009 03:58:42 +0100
> > Alistair Crooks <agc%pkgsrc.org@localhost> wrote:
> > 
> > > On Sun, Oct 18, 2009 at 10:54:33PM -0400, Matthew Mondor wrote:
> > > > while (isspace((int)*value))
> > > >         value++;
> > > 
> > > I'm missing why you would bother casting to (int) in the ctype
> > > macro arg here.
> > 
> > with -Wall:
> > 
> > warning: array subscript has type 'char'
> 
> Indeed.  It might be better to fix the problem at source, since the
> cast we make in NetBSD is to (unsigned char), to avoid negative array
> indexing (where ctype macros are implemented using arrays).

Oh, and if you could make it so that people could reply to your mail,
it'd be great.

   ----- The following addresses had permanent fatal errors -----
<mm_lists%pulsar-zone.net@localhost>
    (reason: 571 Delivery not authorized, message refused)
 
   ----- Transcript of session follows -----
... while talking to smtp.pulsar-zone.net.:
>>> RCPT To:<mm_lists%pulsar-zone.net@localhost> 
<<< 571 Delivery not authorized, message refused
554 5.0.0 Service unavailable

Thanks,
Alistair